Rewrite all deathmessages so they are more minecraft like. #1147

Ghost · 2021-02-18T19:05:38+01:00

Ghost commented

2021-02-18 19:05:38 +01:00

First-time contributor

Lately i noticed that the current mcl_deathmessages mod is not really good.
So i decided to rewrite it.
And here it is.

I added some screenshots.

Lately i noticed that the current mcl_deathmessages mod is not really good. So i decided to rewrite it. And here it is. I added some screenshots.

Screenshot from 2021-02-18 18-05-24.png

5.1 KiB

Screenshot from 2021-02-18 18-05-05.png

9.2 KiB

Screenshot from 2021-02-18 18-04-42.png

9.1 KiB

Screenshot from 2021-02-18 18-03-34.png

7.6 KiB

Screenshot from 2021-02-18 18-06-57.png

5.8 KiB

👍 2

Ghost added 1 commit 2021-02-18 19:05:41 +01:00

ae7c4d7a8b Rewrite all deathmessages

epCode commented

2021-02-18 21:56:03 +01:00

why in some of the slain by's, was some of the msg's say "@1 was slain byn (mob)"? what does "byn" mean?

local mobkills = {
	["mobs_mc:zombie"] = N("@1 was slain by Zombie."),
	["mobs_mc:baby_zombie"] = N("@1 was slain by Baby Zombie."),
	["mobs_mc:blaze"] = N("@1 was burnt to a crisp while fighting Blaze."),
	["mobs_mc:slime"] = N("@1 was slain by Slime."),
	["mobs_mc:witch"] = N("@1 was slain by Witch using magic."),
	["mobs_mc:magma_cube_tiny"] = N("@1 was slain by Magma Cube."),
	["mobs_mc:magma_cube_small"] = N("@1 was slain by Magma Cube."),
	["mobs_mc:magma_cube_big"] = N("@1 was slain by Magma Cube."),
	["mobs_mc:wolf"] = N("@1 was slain by Wolf."),
	["mobs_mc:cat"] = N("@1 was slain by Cat."),
	["mobs_mc:ocelot"] = N("@1 was slain byn Ocelot."),
	["mobs_mc:enderdragon"] = N("@1 was slain byn Enderdragon."),
	["mobs_mc:wither"] = N("@1 was slain by Wither."),
	["mobs_mc:enderman"] = N("@1 was slain byn Enderman."),
	["mobs_mc:endermite"] = N("@1 was slain byn Endermite."),
	["mobs_mc:ghast"] = N("@1 was fireballed by a Ghast."),
	["mobs_mc:guardian_elder"] = N("@1 was slain byn Elder Guardian."),
	["mobs_mc:guardian"] = N("@1 was slain by Guardian."),
	["mobs_mc:iron_golem"] = N("@1 was slain byn Iron Golem."),
	["mobs_mc:polar_bear"] = N("@1 was slain by Polar Bear."),
	["mobs_mc:killer_bunny"] = N("@1 was slain by Killer Bunny."),
	["mobs_mc:shulker"] = N("@1 was slain by Shulker."),
	["mobs_mc:silverfish"] = N("@1 was slain by Silverfish."),
	["mobs_mc:skeleton"] = N("@1 was slain by Skeleton."),
	["mobs_mc:stray"] = N("@1 was slain by Stray."),
	["mobs_mc:slime_tiny"] = N("@1 was slain by Slime."),
	["mobs_mc:slime_small"] = N("@1 was slain by Slime."),
	["mobs_mc:slime_big"] = N("@1 was slain by Slime."),
	["mobs_mc:spider"] = N("@1 was slain by Spider."),
	["mobs_mc:cave_spider"] = N("@1 was slain by Cave spider."),
	["mobs_mc:vex"] = N("@1 was slain by Vex."),
	["mobs_mc:evoker"] = N("@1 was slain byn Evoker."),
	["mobs_mc:illusioner"] = N("@1 was slain byn Illusioner."),
	["mobs_mc:vindicator"] = N("@1 was slain by Vindicator."),
	["mobs_mc:villager_zombie"] = N("@1 was slain by Zombie Villager."),
	["mobs_mc:husk"] = N("@1 was slain by Husk."),
	["mobs_mc:baby_husk"] = N("@1 was slain by Baby Husk."),
	["mobs_mc:pigman"] = N("@1 was slain by Zombie Pigman."),
	["mobs_mc:baby_pigman"] = N("@1 was slain by Baby Zombie Pigman."),

why in some of the slain by's, was some of the msg's say "@1 was slain byn (mob)"? what does "byn" mean? ``` local mobkills = { ["mobs_mc:zombie"] = N("@1 was slain by Zombie."), ["mobs_mc:baby_zombie"] = N("@1 was slain by Baby Zombie."), ["mobs_mc:blaze"] = N("@1 was burnt to a crisp while fighting Blaze."), ["mobs_mc:slime"] = N("@1 was slain by Slime."), ["mobs_mc:witch"] = N("@1 was slain by Witch using magic."), ["mobs_mc:magma_cube_tiny"] = N("@1 was slain by Magma Cube."), ["mobs_mc:magma_cube_small"] = N("@1 was slain by Magma Cube."), ["mobs_mc:magma_cube_big"] = N("@1 was slain by Magma Cube."), ["mobs_mc:wolf"] = N("@1 was slain by Wolf."), ["mobs_mc:cat"] = N("@1 was slain by Cat."), ["mobs_mc:ocelot"] = N("@1 was slain byn Ocelot."), ["mobs_mc:enderdragon"] = N("@1 was slain byn Enderdragon."), ["mobs_mc:wither"] = N("@1 was slain by Wither."), ["mobs_mc:enderman"] = N("@1 was slain byn Enderman."), ["mobs_mc:endermite"] = N("@1 was slain byn Endermite."), ["mobs_mc:ghast"] = N("@1 was fireballed by a Ghast."), ["mobs_mc:guardian_elder"] = N("@1 was slain byn Elder Guardian."), ["mobs_mc:guardian"] = N("@1 was slain by Guardian."), ["mobs_mc:iron_golem"] = N("@1 was slain byn Iron Golem."), ["mobs_mc:polar_bear"] = N("@1 was slain by Polar Bear."), ["mobs_mc:killer_bunny"] = N("@1 was slain by Killer Bunny."), ["mobs_mc:shulker"] = N("@1 was slain by Shulker."), ["mobs_mc:silverfish"] = N("@1 was slain by Silverfish."), ["mobs_mc:skeleton"] = N("@1 was slain by Skeleton."), ["mobs_mc:stray"] = N("@1 was slain by Stray."), ["mobs_mc:slime_tiny"] = N("@1 was slain by Slime."), ["mobs_mc:slime_small"] = N("@1 was slain by Slime."), ["mobs_mc:slime_big"] = N("@1 was slain by Slime."), ["mobs_mc:spider"] = N("@1 was slain by Spider."), ["mobs_mc:cave_spider"] = N("@1 was slain by Cave spider."), ["mobs_mc:vex"] = N("@1 was slain by Vex."), ["mobs_mc:evoker"] = N("@1 was slain byn Evoker."), ["mobs_mc:illusioner"] = N("@1 was slain byn Illusioner."), ["mobs_mc:vindicator"] = N("@1 was slain by Vindicator."), ["mobs_mc:villager_zombie"] = N("@1 was slain by Zombie Villager."), ["mobs_mc:husk"] = N("@1 was slain by Husk."), ["mobs_mc:baby_husk"] = N("@1 was slain by Baby Husk."), ["mobs_mc:pigman"] = N("@1 was slain by Zombie Pigman."), ["mobs_mc:baby_pigman"] = N("@1 was slain by Baby Zombie Pigman."), ```

Ghost commented

2021-02-18 22:08:48 +01:00

First-time contributor

I guess it's a copy-pasted typo. Also there are inconsistencies.
Line 58 / 59 - "ghast" / "Ghast".
EDIT: line 102 / 103 - "spider" / "Spider"
EDIT: line 108 (code / text) - "villager zombie" / "zombie villager"

I guess it's a copy-pasted typo. Also there are inconsistencies. Line 58 / 59 - "ghast" / "Ghast". EDIT: line 102 / 103 - "spider" / "Spider" EDIT: line 108 (code / text) - "villager zombie" / "zombie villager"

Ghost commented

2021-02-19 07:41:10 +01:00

First-time contributor

I'll fix the typo's.

Ghost commented

2021-02-19 07:43:12 +01:00

First-time contributor

I guess it's a copy-pasted typo. Also there are inconsistencies.
Line 58 / 59 - "ghast" / "Ghast".
EDIT: line 102 / 103 - "spider" / "Spider"
EDIT: line 108 (code / text) - "villager zombie" / "zombie villager"

The first one on line 58 / 59 was a typo the rest is correct.
EDIT:
The second and third inconsistencies are because 'villager_zombie' is the name of the registered entity
'mobs_mc:villager_zombie'. But in-game they are called Zombie Villager. The same goes for spider.

> I guess it's a copy-pasted typo. Also there are inconsistencies. > Line 58 / 59 - "ghast" / "Ghast". > EDIT: line 102 / 103 - "spider" / "Spider" > EDIT: line 108 (code / text) - "villager zombie" / "zombie villager" The first one on line 58 / 59 was a typo the rest is correct. EDIT: The second and third inconsistencies are because 'villager_zombie' is the name of the registered entity 'mobs_mc:villager_zombie'. But in-game they are called Zombie Villager. The same goes for spider.

Ghost added 1 commit 2021-02-19 07:43:54 +01:00

c4633db21d Fix some typo's

LizzyFleckenstein03 commented

2021-02-19 09:32:13 +01:00

Uhm, slain by Skeleton? Nah, I don't think so.

Ghost commented

2021-02-19 12:25:12 +01:00

First-time contributor

Then what about: player1 was shot by Skeleton?

👍 2 ❤️ 1

Ghost commented

2021-02-19 12:32:18 +01:00

First-time contributor

For the second one, I was referring to line 103 "Cave spider" not having an upper case "s". Is this intended?
Sorry for the confusion.

For the second one, I was referring to line 103 "Cave spider" not having an upper case "s". Is this intended? Sorry for the confusion.

Ghost added 1 commit 2021-02-19 13:12:49 +01:00

84bfa87fdf Fix some other typo's

Ghost commented

2021-02-19 14:50:01 +01:00

First-time contributor

For the second one, I was referring to line 103 "Cave spider" not having an upper case "s". Is this intended?
Sorry for the confusion.

This was not intended. Sorry for all the typo's everyone.
I fixed it an hour ago @missingcoconut

> For the second one, I was referring to line 103 "Cave spider" not having an upper case "s". Is this intended? > Sorry for the confusion. This was not intended. Sorry for all the typo's everyone. I fixed it an hour ago @missingcoconut

Ghost added 1 commit 2021-02-19 14:52:27 +01:00

f5d2a32e6b Change some deathmessages

Ghost commented

2021-02-19 14:54:17 +01:00

First-time contributor

@EliasFleckenstein03 I changed some of the death-messages so they are more like you want.
Example:

What was: player1 was slain by Skeleton
Is now: player1 was shot by Skeleton

@EliasFleckenstein03 I changed some of the death-messages so they are more like you want. Example: What was: *player1 was slain by Skeleton* Is now: *player1 was shot by Skeleton*

Ghost commented

2021-02-19 17:16:20 +01:00

First-time contributor

Are there any other problems or can this be merged?

LizzyFleckenstein03 commented

2021-02-19 17:41:09 +01:00

There are no problems, but I still need to actually test your code before I merge it :P

Ghost commented

2021-02-19 18:15:27 +01:00

First-time contributor

There are no problems, but I still need to actually test your code before I merge it :P

I understand.
How soon can this be done?

> There are no problems, but I still need to actually test your code before I merge it :P I understand. How soon can this be done?

anon5 commented

2021-02-19 21:34:23 +01:00

First-time contributor

shouldn't it be shot by a skeleton rather than shot by skeleton

shouldn't it be shot by *a* skeleton rather than shot by skeleton

LizzyFleckenstein03 commented

2021-02-20 10:14:03 +01:00

shouldn't it be shot by a skeleton rather than shot by skeleton

Actually I think its "shot by skeleton".

> shouldn't it be shot by *a* skeleton rather than shot by skeleton Actually I think its "shot by skeleton".

LizzyFleckenstein03 commented

2021-02-20 18:26:37 +01:00

ModError: Failed to load and run script from /home/fleckenstein/.minetest/games/MineClone2/mods/HUD/mcl_death_messages/init.lua:
...st/games/MineClone2/mods/HUD/mcl_death_messages/init.lua:97: ')' expected near '.'
Check debug.txt for details.

``` ModError: Failed to load and run script from /home/fleckenstein/.minetest/games/MineClone2/mods/HUD/mcl_death_messages/init.lua: ...st/games/MineClone2/mods/HUD/mcl_death_messages/init.lua:97: ')' expected near '.' Check debug.txt for details. ```

Ghost commented

2021-02-20 18:37:57 +01:00

First-time contributor

Oops, lemme fix that

Ghost added 1 commit 2021-02-20 18:41:13 +01:00

8135110fd4 Fix typo on line 97

Ghost commented

2021-02-20 18:41:24 +01:00

First-time contributor

Try again

LizzyFleckenstein03 commented

2021-02-22 10:19:27 +01:00

Do you even test your code?

2021-02-22 10:17:53: ERROR[Main]: ...../games/MineClone2/mods/HUD/mcl_death_messages/init.lua:97: ')' expected near '.'

Do you even test your code? ``` 2021-02-22 10:17:53: ERROR[Main]: ...../games/MineClone2/mods/HUD/mcl_death_messages/init.lua:97: ')' expected near '.' ```

Ghost commented

2021-02-22 11:03:58 +01:00

First-time contributor

The code works already.
Are you sure you are using the lastest update of my repo?

The code works already. Are you sure you are using the lastest update of my repo?

LizzyFleckenstein03 commented

2021-02-22 11:10:09 +01:00

Yes. It seems like you partially fixed the syntax error when you changed
["mobs_mc:skeleton"] = N("@1 was shot by Skeleton."."),
to
["mobs_mc:skeleton"] = N("@1 was shot by Skeleton.".),, which is still an error tho. Always try to actually RUN it before commiting anything, not matter how sure you are it works - we all make stupid mistakes, and it's very time consuming for everyone if we don't properly test our code before we commit it.

Yes. It seems like you partially fixed the syntax error when you changed `["mobs_mc:skeleton"] = N("@1 was shot by Skeleton."."),` to `["mobs_mc:skeleton"] = N("@1 was shot by Skeleton.".),`, which is still an error tho. Always try to actually RUN it before commiting anything, not matter how sure you are it works - we all make stupid mistakes, and it's very time consuming for everyone if we don't properly test our code before we commit it.

LizzyFleckenstein03 added this to the 0.71.0 milestone 2021-02-22 11:23:16 +01:00

Ghost commented

2021-02-22 11:42:45 +01:00

First-time contributor

I did run it and it worked.
I'll send u a video on discord.

I did run it and it worked. I'll send u a video on discord.

LizzyFleckenstein03 commented

2021-02-22 12:49:12 +01:00

Did you commit / push your latest changes?

kay27 commented

2021-02-22 12:58:32 +01:00

I did run it and it worked.
I'll send u a video on discord.

This line contains redundand point after " before )
Don't waste the time making video, better fix the line.
If I check that, I would fix the line myself, no problem... but with such typos, you contribution looks a bit incomplete. It will affect all the translation templates as well, which seem to be untouched. That's why I hadn't found the time to check it myself, sorry for that, maybe Elias will

> I did run it and it worked. > I'll send u a video on discord. [This line](https://git.minetest.land/MineClone2/MineClone2/src/commit/8135110fd4b2ccc26ea3f723ad95a7e753cb8a9a/mods/HUD/mcl_death_messages/init.lua#L97) contains redundand point after " before ) Don't waste the time making video, better fix the line. If I check that, I would fix the line myself, no problem... but with such typos, you contribution looks a bit incomplete. It will affect all the translation templates as well, which seem to be untouched. That's why I hadn't found the time to check it myself, sorry for that, maybe Elias will

Ghost added 1 commit 2021-02-22 14:03:36 +01:00

89a048e335 Fix another typo

Ghost commented

2021-02-22 14:04:15 +01:00

First-time contributor

My problem is: i can't seem to reproduce the error.
But according to your errors @EliasFleckenstein03, i fixed it.
I hope it works now.

My problem is: i can't seem to reproduce the error. But according to your errors @EliasFleckenstein03, i fixed it. I hope it works now.

LizzyFleckenstein03 merged commit eb62db441b into master

2021-02-22 14:06:54 +01:00

LizzyFleckenstein03 referenced this issue from a commit

2021-02-22 14:06:56 +01:00

Merge pull request 'Rewrite all deathmessages so they are more minecraft like.' (#1147) from Code-Sploit/MineClone2_deathmessages_rewrite:master into master