Cut off desert temple #993

New Issue

Closed

opened 2021-01-20 15:52:09 +01:00 by LizzyFleckenstein03 · 19 comments

LizzyFleckenstein03 commented 2021-01-20 15:52:09 +01:00

Member

Copy Link

Lol what

Lol what

screenshot_20210120_155854.png

476 KiB

LizzyFleckenstein03 added the

bug

label 2021-01-20 16:13:26 +01:00

NO11 commented 2021-01-20 16:18:17 +01:00

Member

Copy Link

bug confirmed, pyramid spawning isn't good. I once had 3 pyramids that "grew" into each other. In addition, the light level in the cut pyramids remains like a closed one

bug confirmed, pyramid spawning isn't good. I once had 3 pyramids that "grew" into each other. In addition, the light level in the cut pyramids remains like a closed one

LizzyFleckenstein03 added the

mapgen

label 2021-01-20 16:49:26 +01:00

kneekoo commented 2021-01-20 17:50:57 +01:00

Contributor

Copy Link

Wow, I didn't know there were structures in MC2. I explored quite a bit, but I found no temples, huts, or anything else. Are they supposed to be so rare? In Minecraft it's not unusual to find desert temples.

Wow, I didn't know there were structures in MC2. I explored quite a bit, but I found no temples, huts, or anything else. Are they supposed to be so rare? In Minecraft it's not unusual to find desert temples.

NO11 commented 2021-01-20 18:33:03 +01:00

Member

Copy Link

I often test and play mineclone2 in survival and I actually always find at least 2 desert temples per desert. Besides, I've already found igloos in survival. They are not uncommon. I just found a strange desert temple that stood on a 10-block high platform. Is that normal?

I often test and play mineclone2 in survival and I actually always find at least 2 desert temples per desert. Besides, I've already found igloos in survival. They are not uncommon. I just found a strange desert temple that stood on a 10-block high platform. Is that normal?

kay27 commented 2021-01-20 21:14:50 +01:00

Contributor

Copy Link

I can (hopefully) fix this by the way I already fixed strongholds:
4c2e28836c
But I have no idea what's wrong with mapgen!

I can (hopefully) fix this by the way I already fixed strongholds: https://git.minetest.land/Wuzzy/MineClone2/commit/4c2e28836cd94cd2f56544bec7fc7d8dce3df01d But I have no idea what's wrong with mapgen!

kay27 referenced this issue from a commit 2021-01-22 15:35:44 +01:00

Quick fix https://git.minetest.land/Wuzzy/MineClone2/issues/993 'Cut off desert temple' by pre-loading the area

kay27 closed this issue 2021-01-22 15:35:44 +01:00

kneekoo commented 2021-02-07 18:06:32 +01:00

Contributor

Copy Link

A few days ago I managed to find two temples in the same desert, and this is one of them:

A few days ago I managed to find two temples in the same desert, and this is one of them: 

LizzyFleckenstein03 commented 2021-02-07 18:39:49 +01:00

Author

Member

Copy Link

It happened to me again as well

It happened to me again as well

LizzyFleckenstein03 reopened this issue 2021-02-07 18:39:51 +01:00

LizzyFleckenstein03 commented 2021-02-07 18:41:01 +01:00

Author

Member

Copy Link

Also:

Also:

screenshot_20210206_205215.png

2.2 MiB

kay27 commented 2021-02-07 21:30:11 +01:00

Contributor

Copy Link

A few days ago I managed to find two temples in the same desert, and this is one of them:

Why do you think it's a desert temple?

@EliasFleckenstein03 wrong biome?! :) wouldn't you please share seed number and coordinates?

> A few days ago I managed to find two temples in the same desert, and this is one of them: Why do you think it's a desert temple? @EliasFleckenstein03 wrong biome?! :) wouldn't you please share seed number and coordinates?

kneekoo commented 2021-02-07 22:04:02 +01:00

Contributor

Copy Link

A few days ago I managed to find two temples in the same desert, and this is one of them:

Why do you think it's a desert temple?

I didn't mean that to sound like it was a bug to find two temples in the same desert. In over a year of playing MC2 I never found one and I assumed they weren't implemented. :) And now that I finally found a temple, go figure - I found another one in the same desert. :))

> > A few days ago I managed to find two temples in the same desert, and this is one of them: > > Why do you think it's a desert temple? I didn't mean that to sound like it was a bug to find two temples in the same desert. In over a year of playing MC2 I never found one and I assumed they weren't implemented. :) And now that I finally found a temple, go figure - I found another one in the same desert. :))

kay27 commented 2021-02-10 16:49:05 +01:00

Contributor

Copy Link

Yep, I couldn't push that commit, that's why it still happen to you and doesn't happen to me.
If a someone has egough privileges please cherry-pick and push it: 4c2e28836c
I've halfly rewritten it locally but this work still needs testing, while the commit mentioned above tested really well, has minor performance issues but all structures exist where they supposed to be

Yep, I couldn't push that commit, that's why it still happen to you and doesn't happen to me. If a someone has egough privileges please cherry-pick and push it: https://git.minetest.land/Wuzzy/MineClone2/commit/4c2e28836cd94cd2f56544bec7fc7d8dce3df01d I've halfly rewritten it locally but this work still needs testing, while the commit mentioned above tested really well, has minor performance issues but all structures exist where they supposed to be

kay27 referenced this issue 2021-02-10 19:47:41 +01:00

Mesehub continuous error 502 #1082

kay27 commented 2021-02-13 01:49:49 +01:00

Contributor

Copy Link

I've done and learnt many things about on_generated but actually not sure what to do.
Firstly all went fine, I thought I had found a way to get_far_node(pos), it was terrible but worked for me and I even tested it with villages but then found error in the code, LOL

local get_node_emerge_queue = {}
local function ecb_get_far_node(blockpos, action, calls_remaining, param)
	if calls_remaining <= 0 and param then
		get_node_emerge_queue[param] = nil
	end
end

function mcl_util.get_far_node(pos, force)
	local node = minetest.get_node(pos)
	if node.name ~= "ignore" then
		return node
	end

	minetest.get_voxel_manip():read_from_map(pos, pos)
	node = minetest.get_node(pos)
	if node.name ~= "ignore" or not force then
		return node
	end

	local blockpos = vector.multiply(vector.floor(vector.divide(pos, mcl_vars.MAP_BLOCKSIZE)), mcl_vars.MAP_BLOCKSIZE)
	local key = minetest.pos_to_string(blockpos)

	for i=1,2 do -- give engine 2 chances to emerge the data
		if not get_node_emerge_queue[key] then
			get_node_emerge_queue[key] = minetest.get_us_time()
			minetest.emerge_area(blockpos, vector.add(blockpos, mcl_vars.MAP_BLOCKSIZE-1), ecb_get_far_node, key)
		end

		while minetest.get_us_time() - (get_node_emerge_queue[key] or 0) < 2000 do end
		
		node = minetest.get_node(pos)
		if node.name ~= "ignore" then
			return node
		end

		minetest.get_voxel_manip():read_from_map(pos, pos)
		node = minetest.get_node(pos)
		if node.name ~= "ignore" or not force then
			return node
		end
	end

	node.name = "air" -- engine continuously returns "ignore" - probably it is a bug
	minetest.swap_node(pos, node) -- engine continuously returns "ignore" - probably it is a bug
	return node -- engine continuously returns "ignore" - probably it is a bug
end

I think it's a garbage now, though it is really the first function which can force engine to stop returning annoying "ignore" nodes even if we read voxels, emerge, wait, etc... but villages mod uses really lot of read operations, so we would wait several game years without any success...

But before I found the error I posted this function as an update to minetest issue https://github.com/minetest/minetest/issues/8232 , then explored the subject and created several tests like that:

minetest.register_on_generated(function(minp, maxp, blockseed)
	local nodes = minetest.find_nodes_in_area(minp, maxp, "ignore")
	if #nodes > 0 then
		minetest.chat_send_all("block "..minetest.pos_to_string(minp).."-"..minetest.pos_to_string(maxp).." : ignore - "..tostring(#nodes) .. "node(s)")
	end
end)

which continuously prints something like that:

and according the docs it's probably wrong, but I still can't be 100% sure the problem isn't in MineClone 2 itself.

There were too many on_generated callbacks registered. So I've organized them in a queue. And still no success.

When we try to manipulate voxels in these callbacks to build dungeons and strongholds, they often just overwrite by stones. When we set nodes - seems it's fine. But voxels supposed to be processed faster. So at least if I can fix the schematics - it will cause slowing down generation speed....

OMG, so many text so little value... I need more information, probably I will push generation queue but before doing that I'm planning to think twice.

Thanks for reading

I've done and learnt many things about on_generated but actually not sure what to do. Firstly all went fine, I thought I had found a way to ```get_far_node(pos)```, it was terrible but worked for me and I even tested it with villages but then found error in the code, LOL ```lua local get_node_emerge_queue = {} local function ecb_get_far_node(blockpos, action, calls_remaining, param) if calls_remaining <= 0 and param then get_node_emerge_queue[param] = nil end end function mcl_util.get_far_node(pos, force) local node = minetest.get_node(pos) if node.name ~= "ignore" then return node end minetest.get_voxel_manip():read_from_map(pos, pos) node = minetest.get_node(pos) if node.name ~= "ignore" or not force then return node end local blockpos = vector.multiply(vector.floor(vector.divide(pos, mcl_vars.MAP_BLOCKSIZE)), mcl_vars.MAP_BLOCKSIZE) local key = minetest.pos_to_string(blockpos) for i=1,2 do -- give engine 2 chances to emerge the data if not get_node_emerge_queue[key] then get_node_emerge_queue[key] = minetest.get_us_time() minetest.emerge_area(blockpos, vector.add(blockpos, mcl_vars.MAP_BLOCKSIZE-1), ecb_get_far_node, key) end while minetest.get_us_time() - (get_node_emerge_queue[key] or 0) < 2000 do end node = minetest.get_node(pos) if node.name ~= "ignore" then return node end minetest.get_voxel_manip():read_from_map(pos, pos) node = minetest.get_node(pos) if node.name ~= "ignore" or not force then return node end end node.name = "air" -- engine continuously returns "ignore" - probably it is a bug minetest.swap_node(pos, node) -- engine continuously returns "ignore" - probably it is a bug return node -- engine continuously returns "ignore" - probably it is a bug end ``` I think it's a garbage now, though it is really the first function which can force engine to stop returning annoying "ignore" nodes even if we read voxels, emerge, wait, etc... but villages mod uses really lot of read operations, so we would wait several game years without any success... But before I found the error I posted this function as an update to minetest issue https://github.com/minetest/minetest/issues/8232 , then explored the subject and created several tests like that: ```lua minetest.register_on_generated(function(minp, maxp, blockseed) local nodes = minetest.find_nodes_in_area(minp, maxp, "ignore") if #nodes > 0 then minetest.chat_send_all("block "..minetest.pos_to_string(minp).."-"..minetest.pos_to_string(maxp).." : ignore - "..tostring(#nodes) .. "node(s)") end end) ``` which continuously prints something like that:  and according the docs it's probably wrong, but I still can't be 100% sure the problem isn't in MineClone 2 itself. There were too many on_generated callbacks registered. So I've organized them in a queue. And still no success. When we try to manipulate voxels in these callbacks to build dungeons and strongholds, they often just overwrite by stones. When we set nodes - seems it's fine. But voxels supposed to be processed faster. So at least if I can fix the schematics - it will cause slowing down generation speed.... OMG, so many text so little value... I need more information, probably I will push generation queue but before doing that I'm planning to think twice. Thanks for reading

image.png

37 KiB

kay27 commented 2021-02-16 13:20:19 +01:00

Contributor

Copy Link

Should that be in End dimension under the islands or it's just my new bug?

Should that be in End dimension under the islands or it's just my new bug? 

изображение.png

248 KiB

LizzyFleckenstein03 commented 2021-02-16 13:49:44 +01:00

Author

Member

Copy Link

It's not a new bug.

It's not a _new_ bug.

kay27 commented 2021-02-16 14:17:12 +01:00

Contributor

Copy Link

Really?.. I hadn't seen before. I was sure v6 mapgen works better but I didn't think 'better' is:

I just tried to shrink area sizes to chunk boundaries and turned off some hacks :) before that I hadn't seen this, only seen the cuts, what's the issue about, but cuts don't fix by these changes, at all.

Locally I've found that when I remove ground_content flag it turns off endless engine map generation, but suitable nor for all cases

Really?.. I hadn't seen before. I was sure v6 mapgen works better but I didn't think 'better' is:  I just tried to shrink area sizes to chunk boundaries and turned off some hacks :) before that I hadn't seen this, only seen the cuts, what's the issue about, but cuts don't fix by these changes, at all. Locally I've found that when I remove ground_content flag it turns off endless engine map generation, but suitable nor for all cases

изображение.png

147 KiB

kay27 referenced this issue 2021-02-16 22:18:39 +01:00

End dimension is probably bugging #1121

kay27 commented 2021-02-20 00:01:28 +01:00

Contributor

Copy Link

I've fixed it locally, debugging now.
What do you think, is it okay (screenshot)?

I've fixed it locally, debugging now. What do you think, is it okay (screenshot)? 

image.png

624 KiB

👍 1

kneekoo commented 2021-02-20 02:38:57 +01:00

Contributor

Copy Link

It looks great, from up here. :P Can the cacti be removed from the temple's body? They're only supposed to grow on sand, and the temples are made out of sandstone. That's the only thing looking unusual.

It looks great, from up here. :P Can the cacti be removed from the temple's body? They're only supposed to grow on sand, and the temples are made out of sandstone. That's the only thing looking unusual.

kay27 commented 2021-02-20 08:46:19 +01:00

Contributor

Copy Link

hope i've trimmed leftovers of cacti, thanks

but this screen was made with increased frequency of spawning desert temples...
with normal one there will be no temples at all, so sad:

i willing to push latest changes to master branch but experience merging problems :) and the result of my war with mapgen are some weird holes near the villages, which I should remove still, hope I'll find a way

hope i've trimmed leftovers of cacti, thanks  but this screen was made with increased frequency of spawning desert temples... with normal one there will be no temples at all, so sad:  i willing to push latest changes to master branch but experience merging problems :) and the result of my war with mapgen are some weird holes near the villages, which I should remove still, hope I'll find a way 

изображение.png

550 KiB

изображение.png

473 KiB

изображение.png

494 KiB

👍 1

kay27 commented 2021-02-20 09:14:15 +01:00

Contributor

Copy Link

The problem is - map generation is slow itself. We should place structures, callback fires as if we really can do that! But still lots of 'ignore' nodes in chunk:

2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (187,160,34), blockpos=(176,160,32) - replacing to air 4096 node(s)
2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (187,176,34), blockpos=(176,176,32) - replacing to air 4096 node(s)
2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (187,192,34), blockpos=(176,192,32) - replacing to air 4096 node(s)
2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,8,17), blockpos=(208,0,16) - replacing to air 3556 node(s)
2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (177,11,57), blockpos=(176,0,48) - replacing to air 3016 node(s)
2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (177,16,57), blockpos=(176,16,48) - replacing to air 2944 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,46,-14), blockpos=(208,32,-16) - replacing to air 3840 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,31,-14), blockpos=(208,16,-16) - replacing to air 4096 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,15,-14), blockpos=(208,0,-16) - replacing to air 4096 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,-1,-14), blockpos=(208,-16,-16) - replacing to air 4096 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,-1,1), blockpos=(208,-16,0) - replacing to air 4096 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,46,17), blockpos=(208,32,16) - replacing to air 3840 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,31,17), blockpos=(208,16,16) - replacing to air 3520 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,-1,17), blockpos=(208,-16,16) - replacing to air 3628 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (211,46,36), blockpos=(208,32,32) - replacing to air 3840 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (211,31,36), blockpos=(208,16,32) - replacing to air 4096 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (211,15,36), blockpos=(208,0,32) - replacing to air 4096 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (211,-1,36), blockpos=(208,-16,32) - replacing to air 4096 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (217,46,-23), blockpos=(208,32,-32) - replacing to air 3840 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (217,31,-23), blockpos=(208,16,-32) - replacing to air 4096 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (217,15,-23), blockpos=(208,0,-32) - replacing to air 4096 node(s)
2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (217,-1,-23), blockpos=(208,-16,-32) - replacing to air 4096 node(s)

! and we wait, wait, wait, but what's next if there are still too many 'ignores'? The picture above is the result when I just replace them by air nodes. Yep, I know, I shouldn't replace "ignore" nodes but I aldo don't know what to do with that. So replacing looks not too bad for me. But still too weird. And the water sources would be weird too:

This minetest issue is more or less about that: https://github.com/minetest/minetest/issues/8232#issuecomment-778869969

This my code just reads the node, as minetest.get_node(pos) should do by design, withoud the part which stores number of chunks generated:

function mcl_mapgen_core.get_far_node(p, force, us_timeout)
	if not p or not p.x or not p.y or not p.z then
		-- minetest.log("warning","[mcl_util] nil passed as node coordinate - return air")
		return {name = "ignore"}
	end
	local node = minetest.get_node(p)
	if node.name ~= "ignore" then
		return node
	end

	local pos = {x=p.x,y=p.y,z=p.z}

	minetest.get_voxel_manip():read_from_map(pos, pos)
	node = minetest.get_node(pos)
	if node.name ~= "ignore" or not force then
		return node
	end

	local blockpos = vector.multiply(vector.floor(vector.divide(pos, mcl_vars.MAP_BLOCKSIZE)), mcl_vars.MAP_BLOCKSIZE)
	local pos2 = vector.add(blockpos, mcl_vars.MAP_BLOCKSIZE-1)

	if mcl_mapgen_core.is_generated(pos) then
		minetest.forceload_block(pos, true)
		local t = minetest.get_us_time()
		local us_timeout = us_timeout or 1000
		node = minetest.get_node(pos)
		while (not node or node.name == "ignore") and (minetest.get_us_time() - t < us_timeout) do
			node = minetest.get_node(pos)
		end
		if node.name ~= "ignore" then
			return node
		end
	else
		local attempts = 5
		local key = minetest.pos_to_string(blockpos)
		local us_timeout = math.floor((us_timeout or 10000) / attempts)

		for i = 1, attempts do -- give engine some chances to emerge the data
			local run = (get_node_emerge_queue[key] ~= nil)
			get_node_emerge_queue[key] = minetest.get_us_time()
			if run then
				minetest.emerge_area(blockpos, pos2, ecb_get_far_node, key)
			end

			while minetest.get_us_time() - (get_node_emerge_queue[key] or 0) < us_timeout do end

			node = minetest.get_node(pos)
			if node.name ~= "ignore" then
				return node
			end

			minetest.get_voxel_manip():read_from_map(pos, pos)
			node = minetest.get_node(pos)
			if node.name ~= "ignore" or not force then
				return node
			end
		end
	end

	 -- engine continuously returns "ignore" - maybe a bug
	node.name = "air"

	local nodes = minetest.find_nodes_in_area(blockpos, pos2, "ignore")
	minetest.log("warning","[mcl_util] still IGNORE at "..minetest.pos_to_string(pos)..", blockpos="..minetest.pos_to_string(blockpos).." - replacing to air "..tostring((#nodes) or 1).. " node(s)")
	if #nodes == 1 then
		minetest.swap_node(pos, node)
	elseif #nodes < 13 then
		minetest.bulk_set_node(nodes, node)
	else
		local manip = minetest.get_voxel_manip()
		local e1, e2 = manip:read_from_map(blockpos, pos2)
		local area = VoxelArea:new{MinEdge=e1, MaxEdge=e2}
		local data = manip:get_data()
		for _, np in pairs(nodes) do
			data[area:index(np.x, np.y, np.z)] = c_air
		end
		manip:set_data(data)
		manip:write_to_map()
	end

	return node
end

The problem is - map generation is slow itself. We should place structures, callback fires as if we really can do that! But still lots of 'ignore' nodes in chunk: ``` 2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (187,160,34), blockpos=(176,160,32) - replacing to air 4096 node(s) 2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (187,176,34), blockpos=(176,176,32) - replacing to air 4096 node(s) 2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (187,192,34), blockpos=(176,192,32) - replacing to air 4096 node(s) 2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,8,17), blockpos=(208,0,16) - replacing to air 3556 node(s) 2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (177,11,57), blockpos=(176,0,48) - replacing to air 3016 node(s) 2021-02-20 11:45:42: WARNING[Emerge-0]: [mcl_util] still IGNORE at (177,16,57), blockpos=(176,16,48) - replacing to air 2944 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,46,-14), blockpos=(208,32,-16) - replacing to air 3840 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,31,-14), blockpos=(208,16,-16) - replacing to air 4096 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,15,-14), blockpos=(208,0,-16) - replacing to air 4096 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,-1,-14), blockpos=(208,-16,-16) - replacing to air 4096 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,-1,1), blockpos=(208,-16,0) - replacing to air 4096 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,46,17), blockpos=(208,32,16) - replacing to air 3840 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,31,17), blockpos=(208,16,16) - replacing to air 3520 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (212,-1,17), blockpos=(208,-16,16) - replacing to air 3628 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (211,46,36), blockpos=(208,32,32) - replacing to air 3840 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (211,31,36), blockpos=(208,16,32) - replacing to air 4096 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (211,15,36), blockpos=(208,0,32) - replacing to air 4096 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (211,-1,36), blockpos=(208,-16,32) - replacing to air 4096 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (217,46,-23), blockpos=(208,32,-32) - replacing to air 3840 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (217,31,-23), blockpos=(208,16,-32) - replacing to air 4096 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (217,15,-23), blockpos=(208,0,-32) - replacing to air 4096 node(s) 2021-02-20 11:45:43: WARNING[Emerge-0]: [mcl_util] still IGNORE at (217,-1,-23), blockpos=(208,-16,-32) - replacing to air 4096 node(s) ``` ! and we wait, wait, wait, but what's next if there are still too many 'ignores'? The picture above is the result when I just replace them by air nodes. Yep, I know, I shouldn't replace "ignore" nodes but I aldo don't know what to do with that. So replacing looks not too bad for me. But still too weird. And the water sources would be weird too:  This minetest issue is more or less about that: https://github.com/minetest/minetest/issues/8232#issuecomment-778869969 This my code just reads the node, as ```minetest.get_node(pos)``` should do by design, withoud the part which stores number of chunks generated: ```lua function mcl_mapgen_core.get_far_node(p, force, us_timeout) if not p or not p.x or not p.y or not p.z then -- minetest.log("warning","[mcl_util] nil passed as node coordinate - return air") return {name = "ignore"} end local node = minetest.get_node(p) if node.name ~= "ignore" then return node end local pos = {x=p.x,y=p.y,z=p.z} minetest.get_voxel_manip():read_from_map(pos, pos) node = minetest.get_node(pos) if node.name ~= "ignore" or not force then return node end local blockpos = vector.multiply(vector.floor(vector.divide(pos, mcl_vars.MAP_BLOCKSIZE)), mcl_vars.MAP_BLOCKSIZE) local pos2 = vector.add(blockpos, mcl_vars.MAP_BLOCKSIZE-1) if mcl_mapgen_core.is_generated(pos) then minetest.forceload_block(pos, true) local t = minetest.get_us_time() local us_timeout = us_timeout or 1000 node = minetest.get_node(pos) while (not node or node.name == "ignore") and (minetest.get_us_time() - t < us_timeout) do node = minetest.get_node(pos) end if node.name ~= "ignore" then return node end else local attempts = 5 local key = minetest.pos_to_string(blockpos) local us_timeout = math.floor((us_timeout or 10000) / attempts) for i = 1, attempts do -- give engine some chances to emerge the data local run = (get_node_emerge_queue[key] ~= nil) get_node_emerge_queue[key] = minetest.get_us_time() if run then minetest.emerge_area(blockpos, pos2, ecb_get_far_node, key) end while minetest.get_us_time() - (get_node_emerge_queue[key] or 0) < us_timeout do end node = minetest.get_node(pos) if node.name ~= "ignore" then return node end minetest.get_voxel_manip():read_from_map(pos, pos) node = minetest.get_node(pos) if node.name ~= "ignore" or not force then return node end end end -- engine continuously returns "ignore" - maybe a bug node.name = "air" local nodes = minetest.find_nodes_in_area(blockpos, pos2, "ignore") minetest.log("warning","[mcl_util] still IGNORE at "..minetest.pos_to_string(pos)..", blockpos="..minetest.pos_to_string(blockpos).." - replacing to air "..tostring((#nodes) or 1).. " node(s)") if #nodes == 1 then minetest.swap_node(pos, node) elseif #nodes < 13 then minetest.bulk_set_node(nodes, node) else local manip = minetest.get_voxel_manip() local e1, e2 = manip:read_from_map(blockpos, pos2) local area = VoxelArea:new{MinEdge=e1, MaxEdge=e2} local data = manip:get_data() for _, np in pairs(nodes) do data[area:index(np.x, np.y, np.z)] = c_air end manip:set_data(data) manip:write_to_map() end return node end ```

изображение.png

512 KiB

❤️ 1

kneekoo commented 2021-02-20 10:17:41 +01:00

Contributor

Copy Link

Thanks for pushing for this. It looks both complicated and messy. I hope the Minetest developers can provide some useful feedback to address the issue.

Thanks for pushing for this. It looks both complicated and messy. I hope the Minetest developers can provide some useful feedback to address the issue.

kay27 referenced this issue from a commit 2021-02-22 00:15:46 +01:00

Add sub-map generators queue, fix https://git.minetest.land/MineClone2/MineClone2/issues/993 and https://git.minetest.land/MineClone2/MineClone2/issues/1060

kay27 closed this issue 2021-02-22 00:15:46 +01:00

kay27 added the

ground content conflict

label 2021-03-26 23:57:08 +01:00

n_to referenced this issue from Mineclonia/Mineclonia 2021-04-23 15:45:30 +02:00

Map generator from Mineclone2 0.71 does not generate decorations (fire, mushrooms, Nether wart) in the Nether #26

kay27 referenced this issue from MineClone5/MineClone5 2022-02-13 01:27:10 +01:00

Too many jungle temples and witch huts generated #192

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

mcl_chests_redo

fix-has_room

upstream/unbreaking_on_crossbows

mcl_mobs_cleanup

mob_ignore_fix

slabs_block_light

hardness_blast_res_fixes

buildable_flowers

burning_in_thunder

redstone-update

add_shader_support

hammers_spears

EE_armor

mapgen_update

projectile-refactor

world_aligned_textures

zombie_texture_improvements

mcl_weathered_nodes

orb_of_exchange

fix_pumpkin_names

patch_skins

hollow_logs_ref_recovery

copper-adaptation-refs-recovery

add_asset_attributions_1

fix_pumpkin_typo_pumkin

cherry_grove

lush_caves

release/0.86.1

mobile_bow_workaround

release/0.85.1

optimize_jukebox_sounds

optimize_theme_ogg

Optimize_backgrounds_jpg

archaeology

spanish-translations

fish_bucket_nametag

villager-golem-fixes

fix_beetroot_fortune_drops

fix_sliding

illager_banner_description

release_0.83.1

skelly_horse_thunder

mobs_armor

mobsarmorfix

smoother_biome_borders

jukebox_sound_distance

cobble_abm_height

callable-tool-rightclick-functions

effects_rewrite

respiration

make-new-music-louder

damage

texture_conversion_wool

dehardcoded_signs

mcl_oxidization

Texture-Rename2

Bamboo-Piston-Dig

hardcore_mode_test

update_german_translation_attempt2

test_mob_tweaks_branch

csm-enabled

move_physics_tweak

water_footstep

biome_skycolor

bambootoo

lower_ow_mapgen

release/0.81.1

revert_chest_models

mcl-craftguide-drop-sfinv

mcl-structures-fixes

turtlestriderbeefox

arrow_node_collision

pvp_knockback

icebergs

light_dump

testing

mobs-redo

wood_api

mobs_head_rotation

bonemeal

dyable-leather-armor

new_mapgen_api

newmobs-master

formspec_overhaul

mobs

mapgen

mineclone5

chat-command-builder-2

formspec-v4

doc-refactoring

production

objects

0.87.2

0.87.1

0.87.0

0.86.2

0.86.1

0.86.0

0.85.0

0.84.0

0.83.1

0.83.0

0.82.0

0.81.1

0.81.0

0.80.1

0.80.0

0.79.0

0.78.0

0.77.0

0.76.0

0.75.0

0.74.0

0.73.1

0.73.0

0.72.1

0.72.0

0.71.0

0.70.0

0.69.1

0.69.0

0.68.0

0.67.2

0.67.1

0.67.0

0.66.2

0.66.1

0.66.0

0.65.2

0.65.1

0.65.0

0.64.0

0.63.0

0.62.0

0.61.0

0.60.0

0.59.2

0.59.1

0.59.0

0.58.1

0.58.0

0.57.1

0.57.0

0.56.2

0.56.1

0.56.0

0.55.1

0.55.0

0.54.1

0.54.0

0.53.4

0.53.3

0.53.2

0.53.1

0.53.0

0.52.1

0.52.0

0.51.1

0.51.0

0.50.2

0.50.1

0.50.0

0.49.0

0.48.1

0.48.0

0.47.1

0.47.0

0.46.0

0.45.1

0.45.0

0.44.0

0.43.0

0.42.0

0.21.0

Labels

Clear labels   

#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  

#P2: HIGH

highest priority level

  

#P3: elevated

2nd-highest priority level

  

#P4 priority: medium

for things that aren't elevated but have been prioritised

  

#P6: low

low priority level

  

#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  

annoying

non-bugs that annoys people

  

API

  

bug

  

code quality

  

combat

  

commands

  

compatibility

Label to cover migration issues from old worlds or mcl5

  

configurability

  

contribution inside

  

controls

  

core feature

  

creative mode

  

delayed for engine release

  

documentation

  

duplicate

  

enhancement

enhancement request/suggestion

  

environment

Issues that affect weather or light

  

gameplay

  

graphics

  

ground content conflict

mapgen gc-specific quirks

  

GUI/HUD

  

help wanted

  

incomplete feature

  

invalid / won't fix

Invalid, or will not fix

  

items

  

looking for contributor

  

mapgen

  

meta

Relating to VoxeLibre on Mesehub and elsewhere

  

mineclone2+

fit for MineClone2-Plus

  

Minecraft >= 1.13

  

Minecraft >= 1.17

  

missing feature

  

mobile

involving Minetest on mobile devices (android)

  

mobs

  

mod support

Issues related to mod support

  

model needed

A model is needed to be created or updated

  

multiplayer

Issues affecting multiplayer

  

Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  

needs discussion

  

needs engine change

  

needs more information

  

needs research

  

nodes

  

non-Minecraft feature

  

non-mob entities

  

performance

  

player

issues related to the player

  

possible close

  

redstone

  

release notes

This ticket will need information adding to release notes

  

schematics

  

Skyblock

  

sounds

  

Testing / Retest

This needs testing or retesting

  

tools

Related to the tools scripts, which aren't run in game

  

translation

  

unconfirmed

  

mcl5

Possibly relevant for MineClone5

  

mcla

Possibly relevant for Mineclonia

  

Media missing

media files for this feature are missing - contributions welcome

No Label

#P1 CRITICAL

#P2: HIGH

#P3: elevated

#P4 priority: medium

#P6: low

#Review

annoying

API

bug

code quality

combat

commands

compatibility

configurability

contribution inside

controls

core feature

creative mode

delayed for engine release

documentation

duplicate

enhancement

environment

gameplay

graphics

ground content conflict

GUI/HUD

help wanted

incomplete feature

invalid / won't fix

items

looking for contributor

mapgen

meta

mineclone2+

Minecraft >= 1.13

Minecraft >= 1.17

missing feature

mobile

mobs

mod support

model needed

multiplayer

Needs adoption

needs discussion

needs engine change

needs more information

needs research

nodes

non-Minecraft feature

non-mob entities

performance

player

possible close

redstone

release notes

schematics

Skyblock

sounds

Testing / Retest

tools

translation

unconfirmed

mcl5

mcla

Media missing

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

4 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#993

No description provided.