VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
56
132
Fork 171
Code Issues 923 Pull Requests 74 Projects 4 Releases Wiki Activity

flat mapgen with updated mcl_spawn mod #1052

New Issue
Closed
opened 2021-02-03 01:29:29 +01:00 by kay27 · 11 comments
kay27 commented 2021-02-03 01:29:29 +01:00
Contributor
Copy Link

@MysticTempest, changing the sign of the operation left biome white list clear for v7 mapgen, and forced the algorithm to search the point until counter overflow. I hope it is now fixed but mod data has been updated and saved, and spawn points moved out of 2000 m from (0,0,0) so I've finally decided to wipe mod storages of my servers to resolve it :)

So dangerous effect. But locating the suitable spawn place isn't an easy task so I'm not sure it's a good idea to calculate it from the middle of the world every server restart...

So I should ask, can't you please check, haven't you experienced crash mentioned here again?

@MysticTempest, changing the sign of the operation left biome white list clear for v7 mapgen, and forced the algorithm to search the point until counter overflow. I hope it is now fixed but mod data has been updated and saved, and spawn points moved out of 2000 m from (0,0,0) so I've finally decided to wipe mod storages of my servers to resolve it :) So dangerous effect. But locating the suitable spawn place isn't an easy task so I'm not sure it's a good idea to calculate it from the middle of the world every server restart... So I should ask, can't you please check, haven't you experienced [crash mentioned here](https://git.minetest.land/MineClone2/MineClone2/commit/d571d62863ca69a151f89175d9de3fe8397f9b79) again?
kay27 added the
mapgen
Testing / Retest
performance
 labels 2021-02-03 01:29:29 +01:00
MysticTempest commented 2021-02-03 03:07:22 +01:00
Member
Copy Link

Ah, sorry bout that.

I just tested your fix against the mapgens that use to be broken before I incorrectly patched them.

v6: Still works.
Singlenode: Still works.
Flat: Broken again. Same error as last time.

2021-02-02 20:02:02: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'mcl_spawn' in callback environment_Step(): ...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:230: wrong number of arguments to 'insert'
2021-02-02 20:02:02: ERROR[Main]: stack traceback:
2021-02-02 20:02:02: ERROR[Main]: 	[C]: in function 'insert'
2021-02-02 20:02:02: ERROR[Main]: 	...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:230: in function 'next_biome'
2021-02-02 20:02:02: ERROR[Main]: 	...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:311: in function 'search'
2021-02-02 20:02:02: ERROR[Main]: 	...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:435: in function 'shadow_worker'
2021-02-02 20:02:02: ERROR[Main]: 	...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:448: in function 'func'
2021-02-02 20:02:02: ERROR[Main]: 	/usr/share/minetest/builtin/common/after.lua:20: in function </usr/share/minetest/builtin/common/after.lua:5>
2021-02-02 20:02:02: ERROR[Main]: 	/usr/share/minetest/builtin/game/register.lua:426: in function </usr/share/minetest/builtin/game/register.lua:410>
2021-02-02 20:02:02: ERROR[Main]: stack traceback:
Ah, sorry bout that. I just tested your fix against the mapgens that use to be broken before I incorrectly patched them. **v6:** Still works. **Singlenode:** Still works. **Flat:** Broken again. Same error as last time. ``` 2021-02-02 20:02:02: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'mcl_spawn' in callback environment_Step(): ...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:230: wrong number of arguments to 'insert' 2021-02-02 20:02:02: ERROR[Main]: stack traceback: 2021-02-02 20:02:02: ERROR[Main]: [C]: in function 'insert' 2021-02-02 20:02:02: ERROR[Main]: ...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:230: in function 'next_biome' 2021-02-02 20:02:02: ERROR[Main]: ...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:311: in function 'search' 2021-02-02 20:02:02: ERROR[Main]: ...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:435: in function 'shadow_worker' 2021-02-02 20:02:02: ERROR[Main]: ...minetest/games/mineclone2/mods/PLAYER/mcl_spawn/init.lua:448: in function 'func' 2021-02-02 20:02:02: ERROR[Main]: /usr/share/minetest/builtin/common/after.lua:20: in function </usr/share/minetest/builtin/common/after.lua:5> 2021-02-02 20:02:02: ERROR[Main]: /usr/share/minetest/builtin/game/register.lua:426: in function </usr/share/minetest/builtin/game/register.lua:410> 2021-02-02 20:02:02: ERROR[Main]: stack traceback: ```
kay27 commented 2021-02-03 09:01:14 +01:00
Author
Contributor
Copy Link

Thanks for the information.
Would you mind telling me the seed number of broken flat world?

Thanks for the information. Would you mind telling me the seed number of broken flat world?
kay27 added
#P1 CRITICAL
 and removed
Testing / Retest
 labels 2021-02-03 09:01:48 +01:00
kay27 changed title from Check singlenode with updated mcl_spawn @MysticTempest to flat mapgen with updated mcl_spawn mod 2021-02-03 09:03:36 +01:00
kay27 added
bug
 and removed
performance
 labels 2021-02-03 09:03:54 +01:00
kay27 self-assigned this 2021-02-03 09:04:04 +01:00
MysticTempest commented 2021-02-03 09:38:11 +01:00
Member
Copy Link

Thanks for the information.
Would you mind telling me the seed number of broken flat world?

Sorry, more specifically; "classic superflat".
Any seed number.

I've had it enabled in the menu settings for so long I forgot it was an optional toggle. It's where I test things out, & create schematics.

> Thanks for the information. > Would you mind telling me the seed number of broken flat world? Sorry, more specifically; "classic superflat". Any seed number. I've had it enabled in the menu settings for so long I forgot it was an optional toggle. It's where I test things out, & create schematics.
kay27 commented 2021-02-03 11:29:05 +01:00
Author
Contributor
Copy Link

Please excuse my stupidity.
I tried to use some flat options and remove all decorations.
It all works.
I need to reproduce the bug.
Can you please write the settings I should make according to https://github.com/minetest/minetest/blob/master/minetest.conf.example#L1743 ?

Update

I've had it enabled in the menu settings for so long I forgot it was an optional toggle. It's where I test things out, & create schematics.

Now I've seen that! Sorry again :) trying to reproduce...

Please excuse my stupidity. I tried to use some flat options and remove all decorations. It all works. I need to reproduce the bug. Can you please write the settings I should make according to https://github.com/minetest/minetest/blob/master/minetest.conf.example#L1743 ? __Update__ > I've had it enabled in the menu settings for so long I forgot it was an optional toggle. It's where I test things out, & create schematics. Now I've seen that! Sorry again :) trying to reproduce...
kay27 commented 2021-02-03 13:09:36 +01:00
Author
Contributor
Copy Link

@MysticTempest have you got some trees there? I pushed a fix but trees are important to make searching loop not too long in time... Maybe I should check how long it takes time to time to interrupt after minute or two...

@MysticTempest have you got some trees there? I pushed a fix but trees are important to make searching loop not too long in time... Maybe I should check how long it takes time to time to interrupt after minute or two...
MysticTempest commented 2021-02-03 13:51:27 +01:00
Member
Copy Link

@MysticTempest have you got some trees there? I pushed a fix but trees are important to make searching loop not too long in time... Maybe I should check how long it takes time to time to interrupt after minute or two...

That fixed it; thanks!

But, you could also maybe just ignore superflat. As it's suppose to be pretty much blank; no trees.

https://minecraft.gamepedia.com/Superflat

https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/MAPGEN/mcl_biomes/init.lua#L3883-L3889

> @MysticTempest have you got some trees there? I pushed a fix but trees are important to make searching loop not too long in time... Maybe I should check how long it takes time to time to interrupt after minute or two... That fixed it; thanks! But, you could also maybe just ignore superflat. As it's suppose to be pretty much blank; no trees. https://minecraft.gamepedia.com/Superflat https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/MAPGEN/mcl_biomes/init.lua#L3883-L3889
kay27 commented 2021-02-03 23:57:26 +01:00
Author
Contributor
Copy Link

Thanks for the feedback!
So, villages shouldn't spawn there? I saw one or two...

Thanks for the feedback! **So, villages shouldn't spawn there? I saw one or two...**
kay27 closed this issue 2021-02-04 00:43:30 +01:00
kay27 commented 2021-02-04 00:52:04 +01:00
Author
Contributor
Copy Link

randomly tested with v5 and got incredible look:

seed=123456789 +Caves +Dungeons +Decorations +Caverns

and that's the spawn point found (after about 40 seconds after world start):
image

with flat + superflat i've broken respawn point several times and the script changes it in next 30 seconds... so hope it will work with any mapgen... but who knows, to be honest, there are lots of mapgen options... you can just set static_spawnpoint, to disable that

randomly tested with v5 and got incredible look: seed=123456789 +Caves +Dungeons +Decorations +Caverns and that's the spawn point found (after about 40 seconds after world start): ![image](/attachments/0671b1c7-7e01-485f-9cb1-b6eb4da85449) --------------- with flat + superflat i've broken respawn point several times and the script changes it in next 30 seconds... so hope it will work with any mapgen... but who knows, to be honest, there are lots of mapgen options... you can just set ```static_spawnpoint```, to disable that
image.png
960 KiB
👍 1
MysticTempest commented 2021-02-04 01:46:09 +01:00
Member
Copy Link

According to the minecraft wiki, villages can spawn in superflat. And, our own villages should occassionally as well.
But, it's not a necessary thing.
Superflat is mostly just a baseplate to build off of.

Ooh, that v5 map looks great! I kinda want to make it one of my new homebases; thanks for the seed and the fixes!

According to the minecraft wiki, villages can spawn in superflat. And, our own villages should occassionally as well. But, it's not a necessary thing. Superflat is mostly just a baseplate to build off of. Ooh, that v5 map looks great! I kinda want to make it one of my new homebases; thanks for the seed and the fixes!
kay27 commented 2021-02-07 16:35:00 +01:00
Author
Contributor
Copy Link

I debugged minecarts on the top of the mountain for some days and now seen this below:
image

I debugged minecarts on the top of the mountain for some days and now seen this below: ![image](/attachments/4934d536-89ef-4f00-856e-aa4897654e94)
image.png
760 KiB
kneekoo commented 2021-02-07 20:30:40 +01:00
Contributor
Copy Link

Yes, the mob spawning still needs a proper implementation.

Yes, the mob spawning still needs a proper implementation.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
mcl_mobs_cleanup
fix-has_room
mob_ignore_fix
slabs_block_light
hardness_blast_res_fixes
flammable-craft-tables
buildable_flowers
burning_in_thunder
redstone-update
add_shader_support
hammers_spears
EE_armor
mapgen_update
projectile-refactor
world_aligned_textures
zombie_texture_improvements
mcl_weathered_nodes
orb_of_exchange
fix_pumpkin_names
patch_skins
hollow_logs_ref_recovery
copper-adaptation-refs-recovery
add_asset_attributions_1
fix_pumpkin_typo_pumkin
cherry_grove
lush_caves
release/0.86.1
mobile_bow_workaround
release/0.85.1
optimize_jukebox_sounds
optimize_theme_ogg
Optimize_backgrounds_jpg
archaeology
spanish-translations
fish_bucket_nametag
villager-golem-fixes
fix_beetroot_fortune_drops
fix_sliding
illager_banner_description
release_0.83.1
skelly_horse_thunder
mobs_armor
mobsarmorfix
smoother_biome_borders
jukebox_sound_distance
cobble_abm_height
callable-tool-rightclick-functions
effects_rewrite
respiration
make-new-music-louder
damage
texture_conversion_wool
dehardcoded_signs
mcl_oxidization
Texture-Rename2
Bamboo-Piston-Dig
hardcore_mode_test
update_german_translation_attempt2
test_mob_tweaks_branch
csm-enabled
move_physics_tweak
water_footstep
biome_skycolor
bambootoo
lower_ow_mapgen
release/0.81.1
revert_chest_models
mcl-craftguide-drop-sfinv
mcl-structures-fixes
turtlestriderbeefox
arrow_node_collision
pvp_knockback
icebergs
light_dump
testing
mobs-redo
wood_api
mobs_head_rotation
bonemeal
dyable-leather-armor
new_mapgen_api
newmobs-master
formspec_overhaul
mobs
mapgen
mineclone5
chat-command-builder-2
formspec-v4
doc-refactoring
production
objects
0.87.1
0.87.0
0.86.2
0.86.1
0.86.0
0.85.0
0.84.0
0.83.1
0.83.0
0.82.0
0.81.1
0.81.0
0.80.1
0.80.0
0.79.0
0.78.0
0.77.0
0.76.0
0.75.0
0.74.0
0.73.1
0.73.0
0.72.1
0.72.0
0.71.0
0.70.0
0.69.1
0.69.0
0.68.0
0.67.2
0.67.1
0.67.0
0.66.2
0.66.1
0.66.0
0.65.2
0.65.1
0.65.0
0.64.0
0.63.0
0.62.0
0.61.0
0.60.0
0.59.2
0.59.1
0.59.0
0.58.1
0.58.0
0.57.1
0.57.0
0.56.2
0.56.1
0.56.0
0.55.1
0.55.0
0.54.1
0.54.0
0.53.4
0.53.3
0.53.2
0.53.1
0.53.0
0.52.1
0.52.0
0.51.1
0.51.0
0.50.2
0.50.1
0.50.0
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.0
0.45.1
0.45.0
0.44.0
0.43.0
0.42.0
0.21.0
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-Minecraft feature

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-Minecraft feature
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#1052
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?