From f9e3c4fd6dd0c7f922eae47bd1e1b2bfdfbb09c8 Mon Sep 17 00:00:00 2001 From: cora Date: Sun, 5 Dec 2021 03:06:33 +0100 Subject: [PATCH] Fix crash when skeleton kills player using bow Commit 5252952555d204e4b5c1a2a4367b36665c476451 used string.gsub() to strip newlines from tools in death messages. The second return value of string.gsub() (the number of substitutions) was erroneously returned too by get_tool_name(). This bug caused a crash whenever a skeleton killed a player using its bow. --- mods/HUD/mcl_death_messages/init.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mods/HUD/mcl_death_messages/init.lua b/mods/HUD/mcl_death_messages/init.lua index aed8c770..837238b5 100644 --- a/mods/HUD/mcl_death_messages/init.lua +++ b/mods/HUD/mcl_death_messages/init.lua @@ -7,7 +7,8 @@ local function get_tool_name(item) local def = item:get_definition() name=def._tt_original_description or def.description end - return name:gsub("[\r\n]"," ") + local sanitized_name, substitution_count = name:gsub("[\r\n]"," ") + return sanitized_name end mcl_death_messages = {}