From 51cdc69b99278edf68c20869a6d57b9926eab633 Mon Sep 17 00:00:00 2001 From: Daniel Cassidy Date: Wed, 5 Jan 2022 23:57:57 +0000 Subject: [PATCH] mcl_mapgen_core: Make mcl_monster_eggs an optional dependency. The only purpose of this dependency appears to be to force mcl_monster_eggs to load before mcl_mapgen_core. It is not actually used in the code. mcl_monster_eggs is an undeclared dependency of mobs_mc_gameconfig, mcl_biomes, and mcl_structures, all of which are either transitive or direct dependencies of mcl_mapgen_core. It's not possible to add a dependency on mcl_monster_eggs directly to mobs_mc_gameconfig, because that would lead to a circular dependency. So it seems like a dependency on mcl_monster_eggs is declared as a dependency of mcl_mapgen_core as a workaround to ensure that mcl_monster_eggs at least gets loaded before mcl_mapgen_core. I've moved mcl_monster_eggs to the optional dependencies which should achieve the same aim without complaining if mcl_monster_eggs is missing, but this should probably be cleaned up in future to remove the circular dependency. --- mods/MAPGEN/mcl_mapgen_core/mod.conf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/MAPGEN/mcl_mapgen_core/mod.conf b/mods/MAPGEN/mcl_mapgen_core/mod.conf index f88a735f5..9fe207ead 100644 --- a/mods/MAPGEN/mcl_mapgen_core/mod.conf +++ b/mods/MAPGEN/mcl_mapgen_core/mod.conf @@ -1,5 +1,5 @@ name = mcl_mapgen_core author = Wuzzy description = The core of the MCL2 mapgen -depends = mcl_init, mcl_core, biomeinfo, mcl_worlds, mcl_stairs, mcl_monster_eggs, mcl_structures -optional_depends = mclx_core, mcl_cocoas, mcl_sponges, mcl_ocean +depends = mcl_init, mcl_core, biomeinfo, mcl_worlds, mcl_stairs, mcl_structures +optional_depends = mclx_core, mcl_cocoas, mcl_sponges, mcl_ocean, mcl_monster_eggs