forked from VoxeLibre/VoxeLibre
if -> only when
This commit is contained in:
parent
fb2a501a9c
commit
4db9952a84
|
@ -338,9 +338,9 @@ MineClone2 repository.
|
||||||
MineClone2 master - rather, do your work on a branch on your private
|
MineClone2 master - rather, do your work on a branch on your private
|
||||||
repo, then create a pull request. This way other people can review your
|
repo, then create a pull request. This way other people can review your
|
||||||
changes and make sure they work before they get merged.
|
changes and make sure they work before they get merged.
|
||||||
- Merge PRs if they have recieved the necessary feedback and have been
|
- Merge PRs only when they have recieved the necessary feedback and have
|
||||||
tested to not lead to any crashes and do what they claim to do by at
|
been tested to not lead to any crashes and do what they claim to do by
|
||||||
least two different people.
|
at least two different people.
|
||||||
- You may also be assigned to issues or pull
|
- You may also be assigned to issues or pull
|
||||||
requests as a developer. In this case it is your responsibility to fix
|
requests as a developer. In this case it is your responsibility to fix
|
||||||
the issue / review and merge the pull request when it is ready. You can
|
the issue / review and merge the pull request when it is ready. You can
|
||||||
|
|
Loading…
Reference in New Issue