From 3ef10cfb307a5838bed2497434a4e4fdf883a9b1 Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Sat, 13 Mar 2021 11:12:26 +0100
Subject: [PATCH] add API for mcl_crafting_table and cache functions for better
 performances

---
 mods/ITEMS/mcl_crafting_table/depends.txt     |  3 --
 mods/ITEMS/mcl_crafting_table/description.txt |  1 -
 mods/ITEMS/mcl_crafting_table/init.lua        | 53 +++++++++++--------
 mods/ITEMS/mcl_crafting_table/mod.conf        |  3 ++
 4 files changed, 35 insertions(+), 25 deletions(-)
 delete mode 100644 mods/ITEMS/mcl_crafting_table/depends.txt
 delete mode 100644 mods/ITEMS/mcl_crafting_table/description.txt

diff --git a/mods/ITEMS/mcl_crafting_table/depends.txt b/mods/ITEMS/mcl_crafting_table/depends.txt
deleted file mode 100644
index 97aafc582b..0000000000
--- a/mods/ITEMS/mcl_crafting_table/depends.txt
+++ /dev/null
@@ -1,3 +0,0 @@
-mcl_init
-mcl_formspec
-mcl_sounds
diff --git a/mods/ITEMS/mcl_crafting_table/description.txt b/mods/ITEMS/mcl_crafting_table/description.txt
deleted file mode 100644
index 5f2a79786c..0000000000
--- a/mods/ITEMS/mcl_crafting_table/description.txt
+++ /dev/null
@@ -1 +0,0 @@
-Adds a crafting table.
diff --git a/mods/ITEMS/mcl_crafting_table/init.lua b/mods/ITEMS/mcl_crafting_table/init.lua
index 09c4838cd1..4ad581774e 100644
--- a/mods/ITEMS/mcl_crafting_table/init.lua
+++ b/mods/ITEMS/mcl_crafting_table/init.lua
@@ -1,5 +1,36 @@
 local S = minetest.get_translator("mcl_crafting_table")
+local formspec_escape = minetest.formspec_escape
+local show_formspec = minetest.show_formspec
+local C = minetest.colorize
+local text_color = mcl_colors.BLACK or "#313131"
+local itemslot_bg = mcl_formspec.get_itemslot_bg
 
+mcl_crafting_table = {}
+function mcl_crafting_table.show_crafting_form(player)
+	player:get_inventory():set_width("craft", 3)
+	player:get_inventory():set_size("craft", 9)
+
+	show_formspec(player:get_player_name(), "main",
+		"size[9,8.75]"..
+		"image[4.7,1.5;1.5,1;gui_crafting_arrow.png]"..
+		"label[0,4;"..formspec_escape(C(text_color, S("Inventory"))).."]".. --"#313131"
+		"list[current_player;main;0,4.5;9,3;9]"..
+		itemslot_bg(0,4.5,9,3)..
+		"list[current_player;main;0,7.74;9,1;]"..
+		itemslot_bg(0,7.74,9,1)..
+		"label[1.75,0;"..formspec_escape(C(text_color, S("Crafting"))).."]"..
+		"list[current_player;craft;1.75,0.5;3,3;]"..
+		itemslot_bg(1.75,0.5,3,3)..
+		"list[current_player;craftpreview;6.1,1.5;1,1;]"..
+		itemslot_bg(6.1,1.5,1,1)..
+		"image_button[0.75,1.5;1,1;craftguide_book.png;__mcl_craftguide;]"..
+		"tooltip[__mcl_craftguide;"..formspec_escape(S("Recipe book")).."]"..
+		"listring[current_player;main]"..
+		"listring[current_player;craft]"
+	)
+end
+
+local show_crafting_form = mcl_crafting_table.show_crafting_form  --cache function for better performances
 minetest.register_node("mcl_crafting_table:crafting_table", {
 	description = S("Crafting Table"),
 	_tt_help = S("3×3 crafting grid"),
@@ -12,27 +43,7 @@ minetest.register_node("mcl_crafting_table:crafting_table", {
 	paramtype2 = "facedir",
 	groups = {handy=1,axey=1, deco_block=1, material_wood=1,flammable=-1},
 	on_rightclick = function(pos, node, player, itemstack)
-		player:get_inventory():set_width("craft", 3)
-		player:get_inventory():set_size("craft", 9)
-
-		local form = "size[9,8.75]"..
-		"image[4.7,1.5;1.5,1;gui_crafting_arrow.png]"..
-		"label[0,4;"..minetest.formspec_escape(minetest.colorize("#313131", S("Inventory"))).."]"..
-		"list[current_player;main;0,4.5;9,3;9]"..
-		mcl_formspec.get_itemslot_bg(0,4.5,9,3)..
-		"list[current_player;main;0,7.74;9,1;]"..
-		mcl_formspec.get_itemslot_bg(0,7.74,9,1)..
-		"label[1.75,0;"..minetest.formspec_escape(minetest.colorize("#313131", S("Crafting"))).."]"..
-		"list[current_player;craft;1.75,0.5;3,3;]"..
-		mcl_formspec.get_itemslot_bg(1.75,0.5,3,3)..
-		"list[current_player;craftpreview;6.1,1.5;1,1;]"..
-		mcl_formspec.get_itemslot_bg(6.1,1.5,1,1)..
-		"image_button[0.75,1.5;1,1;craftguide_book.png;__mcl_craftguide;]"..
-		"tooltip[__mcl_craftguide;"..minetest.formspec_escape(S("Recipe book")).."]"..
-		"listring[current_player;main]"..
-		"listring[current_player;craft]"
-
-		minetest.show_formspec(player:get_player_name(), "main", form)
+		show_crafting_form(player)
 	end,
 	sounds = mcl_sounds.node_sound_wood_defaults(),
 	_mcl_blast_resistance = 2.5,
diff --git a/mods/ITEMS/mcl_crafting_table/mod.conf b/mods/ITEMS/mcl_crafting_table/mod.conf
index db5ab14a1a..03b3174ab1 100644
--- a/mods/ITEMS/mcl_crafting_table/mod.conf
+++ b/mods/ITEMS/mcl_crafting_table/mod.conf
@@ -1 +1,4 @@
 name = mcl_crafting_table
+description = Adds a crafting table.
+depends = mcl_init, mcl_formspec, mcl_sounds
+optional_depends = mcl_colors