From 640b0dc4859014f15939cce0be36dd06c2b1419c Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Wed, 2 Jun 2021 00:23:11 +0200
Subject: [PATCH 01/12] basic title API working (testing needed)

---
 mods/HUD/mcl_title/init.lua | 161 ++++++++++++++++++++++++++++++++++++
 mods/HUD/mcl_title/mod.conf |   4 +
 2 files changed, 165 insertions(+)
 create mode 100644 mods/HUD/mcl_title/init.lua
 create mode 100644 mods/HUD/mcl_title/mod.conf

diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
new file mode 100644
index 0000000000..9975ff840f
--- /dev/null
+++ b/mods/HUD/mcl_title/init.lua
@@ -0,0 +1,161 @@
+--TODO: use SSCSM to reduce lag and network trafic (just send modchannel messages)
+--TODO: exactly mc like layout
+
+local huds_idx = {}
+
+huds_idx.title = {}
+huds_idx.subtitle = {}
+huds_idx.actionbar = {}
+
+mcl_title = {}
+mcl_title.defaults = {fadein = 10, stay = 70, fadeout = 20}
+mcl_title.layout = {}
+mcl_title.layout.title = {position = {x = 0.5, y = 0.5}, alignment = {x = 0, y = -1.3}, size = 5}
+mcl_title.layout.subtitle = {position = {x = 0.5, y = 0.5}, alignment = {x = 0, y = 1.9}, size = 2}
+mcl_title.layout.actionbar = {position = {x = 0.5, y = 1}, alignment = {x = 0, y = -15}, size = 1}
+
+local get_color = mcl_util.get_color
+
+local function gametick_to_secondes(gametick)
+	return gametick / 20
+end
+
+
+--PARAMS SYSTEM
+local player_params = {}
+
+minetest.register_on_joinplayer(function(player)
+	player_params[player] = {
+		stay = gametick_to_secondes(mcl_title.defaults.stay),
+		--fadeIn = gametick_to_secondes(mcl_title.defaults.fadein),
+		--fadeOut = gametick_to_secondes(mcl_title.defaults.fadeout),
+	}	
+end)
+
+minetest.register_on_leaveplayer(function(player)
+	player_params = nil
+end)
+
+function mcl_title.params_set(player, data)
+	player_params[player] = {
+		stay = gametick_to_secondes(data.stay) or gametick_to_secondes(mcl_title.defaults.stay),
+		--fadeIn = gametick_to_secondes(data.fadeIn) or gametick_to_secondes(mcl_title.defaults.fadein),
+		--fadeOut = gametick_to_secondes(data.fadeOut) or gametick_to_secondes(mcl_title.defaults.fadeout),
+	}
+end
+
+function mcl_title.params_get(player)
+	return player_params[player]
+end
+
+--API FUNCTIONS
+
+function mcl_title.set(player, type, data)
+	if not data.color then
+		data.color = "white"
+	end
+	local _, hex_color = get_color(data.color)
+	if not hex_color then
+		return false
+	end
+
+	if huds_idx[type][player] then
+		player:hud_remove(huds_idx[type][player])
+	end
+
+	--TODO: enable this code then Fleckenstein's pr get merged
+	--[[
+	local bold
+	if data.bold == "true" then
+		bold = true
+	else
+		bold = false
+	end
+
+	local italic
+	if data.italic == "true" then
+		italic = true
+	else
+		italic = false
+	end]]
+
+	local stay = mcl_title.params_get(player).stay
+
+	huds_idx[type][player] = player:hud_add({
+		hud_elem_type = "text",
+		position  = mcl_title.layout[type].position,
+		alignment = mcl_title.layout[type].alignment,
+		text      = data.text,
+		--bold = bold,
+		--italic = italic,
+		size      = {x = mcl_title.layout[type].size},
+		number    = hex_color,
+		z_index   = 1100,
+	})
+
+	minetest.after(stay, function()
+		if huds_idx[type][player] then
+			player:hud_remove(huds_idx[type][player])
+		end
+		huds_idx[type][player] = nil
+	end)
+	return true
+end
+
+function mcl_title.remove(player, type)
+	if huds_idx[type][player] then
+		player:hud_remove(huds_idx[type][player])
+	end
+	huds_idx[type][player] = nil
+end
+
+function mcl_title.clear(player)
+	mcl_title.remove(player, "title")
+	mcl_title.remove(player, "subtitle")
+	mcl_title.remove(player, "actionbar")
+end
+
+minetest.register_on_dieplayer(function(player)
+	mcl_title.clear(player)
+end)
+
+
+--TEMP STUFF!!
+--TODO: remove then testing/tweaking done
+minetest.register_chatcommand("title", {
+	func = function(name, param)
+		local player = minetest.get_player_by_name(name)
+		mcl_title.set(player, "title", {text=param, color="gold"})
+	end,
+})
+
+minetest.register_chatcommand("subtitle", {
+	func = function(name, param)
+		local player = minetest.get_player_by_name(name)
+		mcl_title.set(player, "subtitle", {text=param, color="gold"})
+	end,
+})
+
+minetest.register_chatcommand("actionbar", {
+	func = function(name, param)
+		local player = minetest.get_player_by_name(name)
+		mcl_title.set(player, "actionbar", {text=param, color="gold"})
+	end,
+})
+
+minetest.register_chatcommand("timeout", {
+	func = function(name, param)
+		local player = minetest.get_player_by_name(name)
+		mcl_title.params_set(player, {stay = 600})
+	end,
+})
+
+minetest.register_chatcommand("all", {
+	func = function(name, param)
+		local player = minetest.get_player_by_name(name)
+		mcl_title.params_set(player, {stay = 600})
+		mcl_title.set(player, "title", {text=param, color="gold"})
+		mcl_title.set(player, "subtitle", {text=param, color="gold"})
+		mcl_title.set(player, "actionbar", {text=param, color="gold"})
+	end,
+})
\ No newline at end of file
diff --git a/mods/HUD/mcl_title/mod.conf b/mods/HUD/mcl_title/mod.conf
new file mode 100644
index 0000000000..0f29a8118c
--- /dev/null
+++ b/mods/HUD/mcl_title/mod.conf
@@ -0,0 +1,4 @@
+name = mcl_title
+description = Add an API to add in HUD title 
+depends = mcl_colors
+author = AFCMS
\ No newline at end of file

From 6b53dda79bf8b31309206ea29b6e84184cc17fc7 Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Wed, 2 Jun 2021 00:25:15 +0200
Subject: [PATCH 02/12] add todo list

---
 mods/HUD/mcl_title/init.lua | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index 9975ff840f..41b4dfc4a7 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -1,4 +1,5 @@
 --TODO: use SSCSM to reduce lag and network trafic (just send modchannel messages)
+--TODO: fadeIn and fadeOut animation (needs engine change: SSCSM or native support)
 --TODO: exactly mc like layout
 
 local huds_idx = {}

From c8102838cb80e5ada8649a7ccf48c1c288a4de2b Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Wed, 2 Jun 2021 00:26:10 +0200
Subject: [PATCH 03/12] add missing TODO entry (bold+italic)

---
 mods/HUD/mcl_title/init.lua | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index 41b4dfc4a7..807ed19c98 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -65,6 +65,7 @@ function mcl_title.set(player, type, data)
 	end
 
 	--TODO: enable this code then Fleckenstein's pr get merged
+	--TODO: be sure API is correctly used
 	--[[
 	local bold
 	if data.bold == "true" then

From 7e64470f7086c2978f0ad48710d6c0f253b6c3cb Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Wed, 2 Jun 2021 11:07:31 +0200
Subject: [PATCH 04/12] fix future API usage of bold+italic pr

---
 mods/HUD/mcl_title/init.lua | 22 +++++-----------------
 1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index 807ed19c98..83277b3bf5 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -64,22 +64,10 @@ function mcl_title.set(player, type, data)
 		player:hud_remove(huds_idx[type][player])
 	end
 
-	--TODO: enable this code then Fleckenstein's pr get merged
-	--TODO: be sure API is correctly used
-	--[[
-	local bold
-	if data.bold == "true" then
-		bold = true
-	else
-		bold = false
-	end
+	--TODO: enable this code then Fleckenstein's pr get merged (in about 5-6 years)
 
-	local italic
-	if data.italic == "true" then
-		italic = true
-	else
-		italic = false
-	end]]
+	--if data.bold == nil then data.bold = false end
+	--if data.italic == nil then data.italic = false end
 
 	local stay = mcl_title.params_get(player).stay
 
@@ -88,8 +76,8 @@ function mcl_title.set(player, type, data)
 		position  = mcl_title.layout[type].position,
 		alignment = mcl_title.layout[type].alignment,
 		text      = data.text,
-		--bold = bold,
-		--italic = italic,
+		--bold = data.bold,
+		--italic = data.italic,
 		size      = {x = mcl_title.layout[type].size},
 		number    = hex_color,
 		z_index   = 1100,

From b9fd1ac227c59407a92ca208d1fd71681c7952f0 Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Wed, 2 Jun 2021 11:12:15 +0200
Subject: [PATCH 05/12] credit digminecraft for the tutorial

---
 mods/HUD/mcl_title/init.lua | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index 83277b3bf5..a2fd82b24c 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -1,3 +1,5 @@
+--Based on https://www.digminecraft.com/game_commands/title_command.php
+
 --TODO: use SSCSM to reduce lag and network trafic (just send modchannel messages)
 --TODO: fadeIn and fadeOut animation (needs engine change: SSCSM or native support)
 --TODO: exactly mc like layout

From 2603c4768ba34be059b8f3dd175985bc08683cea Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Mon, 7 Jun 2021 22:32:05 +0200
Subject: [PATCH 06/12] mcl_title: basic mc like layout (collide with other
 mods)

---
 mods/HUD/mcl_title/init.lua | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index a2fd82b24c..ffd740b4a8 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -1,7 +1,11 @@
---Based on https://www.digminecraft.com/game_commands/title_command.php
+--Based on:
+--https://www.digminecraft.com/game_commands/title_command.php
+--https://youtu.be/oVrtQRO2hpY
 
 --TODO: use SSCSM to reduce lag and network trafic (just send modchannel messages)
 --TODO: fadeIn and fadeOut animation (needs engine change: SSCSM or native support)
+--TODO: allow obfuscating text (needs engine change: SSCSM or native support)
+--TODO: allow colorizing and styling of part of the text (NEEDS ENGINE CHANGE!!!)
 --TODO: exactly mc like layout
 
 local huds_idx = {}
@@ -13,9 +17,9 @@ huds_idx.actionbar = {}
 mcl_title = {}
 mcl_title.defaults = {fadein = 10, stay = 70, fadeout = 20}
 mcl_title.layout = {}
-mcl_title.layout.title = {position = {x = 0.5, y = 0.5}, alignment = {x = 0, y = -1.3}, size = 5}
-mcl_title.layout.subtitle = {position = {x = 0.5, y = 0.5}, alignment = {x = 0, y = 1.9}, size = 2}
-mcl_title.layout.actionbar = {position = {x = 0.5, y = 1}, alignment = {x = 0, y = -15}, size = 1}
+mcl_title.layout.title = {position = {x = 0.5, y = 0.5}, alignment = {x = 0, y = -1.3}, size = 7}
+mcl_title.layout.subtitle = {position = {x = 0.5, y = 0.5}, alignment = {x = 0, y = 1.7}, size = 4}
+mcl_title.layout.actionbar = {position = {x = 0.5, y = 1}, alignment = {x = 0, y = -11}, size = 2}
 
 local get_color = mcl_util.get_color
 

From 8e931e92f57ce18792a846828e0e942f52f8eef1 Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Fri, 9 Jul 2021 11:34:23 +0200
Subject: [PATCH 07/12] refactor mcl_title to be more efficient

---
 mods/HUD/mcl_title/init.lua | 120 +++++++++++++++++++++++++++---------
 1 file changed, 90 insertions(+), 30 deletions(-)

diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index ffd740b4a8..48c3a909f7 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -8,8 +8,17 @@
 --TODO: allow colorizing and styling of part of the text (NEEDS ENGINE CHANGE!!!)
 --TODO: exactly mc like layout
 
+--Note that the table storing timeouts use playername as index insteed of player objects (faster)
+--This is intended in order to speedup the process of removing HUD elements the the timeout is up
+
 local huds_idx = {}
 
+local hud_hide_timeouts = {}
+
+hud_hide_timeouts.title = {}
+hud_hide_timeouts.subtitle = {}
+hud_hide_timeouts.actionbar = {}
+
 huds_idx.title = {}
 huds_idx.subtitle = {}
 huds_idx.actionbar = {}
@@ -19,10 +28,13 @@ mcl_title.defaults = {fadein = 10, stay = 70, fadeout = 20}
 mcl_title.layout = {}
 mcl_title.layout.title = {position = {x = 0.5, y = 0.5}, alignment = {x = 0, y = -1.3}, size = 7}
 mcl_title.layout.subtitle = {position = {x = 0.5, y = 0.5}, alignment = {x = 0, y = 1.7}, size = 4}
-mcl_title.layout.actionbar = {position = {x = 0.5, y = 1}, alignment = {x = 0, y = -11}, size = 2}
+mcl_title.layout.actionbar = {position = {x = 0.5, y = 1}, alignment = {x = 0, y = 0}, size = 1}
 
 local get_color = mcl_util.get_color
 
+local string = string
+local pairs = pairs
+
 local function gametick_to_secondes(gametick)
 	return gametick / 20
 end
@@ -32,15 +44,64 @@ end
 local player_params = {}
 
 minetest.register_on_joinplayer(function(player)
-	player_params[player] = {
+	local playername = player:get_player_name()
+	player_params[playername] = {
 		stay = gametick_to_secondes(mcl_title.defaults.stay),
 		--fadeIn = gametick_to_secondes(mcl_title.defaults.fadein),
 		--fadeOut = gametick_to_secondes(mcl_title.defaults.fadeout),
-	}	
+	}
+	local _, hex_color = get_color("white") 
+	huds_idx.title[player] = player:hud_add({
+		hud_elem_type = "text",
+		position  = mcl_title.layout.title.position,
+		alignment = mcl_title.layout.title.alignment,
+		text      = "",
+		--bold    = data.bold,
+		--italic  = data.italic,
+		size      = {x = mcl_title.layout.title.size},
+		number    = hex_color,
+		z_index   = 100,
+	})
+	huds_idx.subtitle[player] = player:hud_add({
+		hud_elem_type = "text",
+		position  = mcl_title.layout.subtitle.position,
+		alignment = mcl_title.layout.subtitle.alignment,
+		text      = "",
+		--bold    = data.bold,
+		--italic  = data.italic,
+		size      = {x = mcl_title.layout.subtitle.size},
+		number    = hex_color,
+		z_index   = 100,
+	})
+	huds_idx.actionbar[player] = player:hud_add({
+		hud_elem_type = "text",
+		position  = mcl_title.layout.actionbar.position,
+		offset    = {x = 0, y = -210},
+		alignment = mcl_title.layout.actionbar.alignment,
+		--bold    = data.bold,
+		--italic  = data.italic,
+		text      = "",
+		size      = {x = mcl_title.layout.actionbar.size},
+		number    = hex_color,
+		z_index   = 100,
+	})
 end)
 
 minetest.register_on_leaveplayer(function(player)
-	player_params = nil
+	local playername = player:get_player_name()
+
+	--remove player params from the list
+	player_params[player] = nil
+
+	--remove HUD idx from the list (HUD elements are removed by the engine)
+	huds_idx.title[player] = nil
+	huds_idx.subtitle[player] = nil
+	huds_idx.actionbar[player] = nil
+
+	--remove timers form list
+	hud_hide_timeouts.title[playername] = nil
+	hud_hide_timeouts.subtitle[playername] = nil
+	hud_hide_timeouts.actionbar[playername] = nil
 end)
 
 function mcl_title.params_set(player, data)
@@ -66,43 +127,22 @@ function mcl_title.set(player, type, data)
 		return false
 	end
 
-	if huds_idx[type][player] then
-		player:hud_remove(huds_idx[type][player])
-	end
-
 	--TODO: enable this code then Fleckenstein's pr get merged (in about 5-6 years)
 
 	--if data.bold == nil then data.bold = false end
 	--if data.italic == nil then data.italic = false end
 
-	local stay = mcl_title.params_get(player).stay
+	player:hud_change(huds_idx[type][player], "text", data.text)
+	player:hud_change(huds_idx[type][player], "number", hex_color)
 
-	huds_idx[type][player] = player:hud_add({
-		hud_elem_type = "text",
-		position  = mcl_title.layout[type].position,
-		alignment = mcl_title.layout[type].alignment,
-		text      = data.text,
-		--bold = data.bold,
-		--italic = data.italic,
-		size      = {x = mcl_title.layout[type].size},
-		number    = hex_color,
-		z_index   = 1100,
-	})
-
-	minetest.after(stay, function()
-		if huds_idx[type][player] then
-			player:hud_remove(huds_idx[type][player])
-		end
-		huds_idx[type][player] = nil
-	end)
+	hud_hide_timeouts[type][player:get_player_name()] = data.stay or mcl_title.params_get(player).stay
 	return true
 end
 
 function mcl_title.remove(player, type)
-	if huds_idx[type][player] then
-		player:hud_remove(huds_idx[type][player])
+	if player then
+		player:hud_change(huds_idx[type][player], "text", "")
 	end
-	huds_idx[type][player] = nil
 end
 
 function mcl_title.clear(player)
@@ -115,6 +155,26 @@ minetest.register_on_dieplayer(function(player)
 	mcl_title.clear(player)
 end)
 
+minetest.register_globalstep(function(dtime)
+	local new_timeouts = {
+		title = {},
+		subtitle = {},
+		actionbar = {},
+	}
+	for element, content in pairs(hud_hide_timeouts) do
+		for name, timeout in pairs(content) do
+			timeout = timeout - dtime
+			if timeout <= 0 then
+				local player = minetest.get_player_by_name(name)
+				mcl_title.remove(player, element)
+			else
+				new_timeouts[element][name] = timeout
+			end
+		end
+	end
+	hud_hide_timeouts = new_timeouts
+end)
+
 
 --TEMP STUFF!!
 --TODO: remove then testing/tweaking done

From b5f7ae54583197b55bb5e8f5f81a6605fa4f74e8 Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Tue, 20 Jul 2021 15:47:26 +0200
Subject: [PATCH 08/12] working implementation + support of other mods

---
 mods/ENTITIES/mcl_boats/init.lua     | 2 +-
 mods/ENTITIES/mcl_boats/mod.conf     | 2 +-
 mods/ENTITIES/mcl_minecarts/init.lua | 2 +-
 mods/ENTITIES/mcl_minecarts/mod.conf | 2 +-
 mods/HUD/mcl_title/init.lua          | 5 ++---
 mods/ITEMS/mcl_beds/functions.lua    | 2 +-
 6 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/mods/ENTITIES/mcl_boats/init.lua b/mods/ENTITIES/mcl_boats/init.lua
index 76ace7a45b..e81e9ffc5d 100644
--- a/mods/ENTITIES/mcl_boats/init.lua
+++ b/mods/ENTITIES/mcl_boats/init.lua
@@ -84,7 +84,7 @@ local function attach_object(self, obj)
 			end
 		end, name)
 		obj:set_look_horizontal(yaw)
-		mcl_tmp_message.message(obj, S("Sneak to dismount"))
+		mcl_title.set(obj, "actionbar", {text=S("Sneak to dismount"), color="white", stay=3})
 	else
 		obj:get_luaentity()._old_visual_size = visual_size
 	end
diff --git a/mods/ENTITIES/mcl_boats/mod.conf b/mods/ENTITIES/mcl_boats/mod.conf
index a5d6cc8cb4..61463b6ec2 100644
--- a/mods/ENTITIES/mcl_boats/mod.conf
+++ b/mods/ENTITIES/mcl_boats/mod.conf
@@ -1,7 +1,7 @@
 name = mcl_boats
 author = PilzAdam
 description = Adds drivable boats.
-depends = mcl_player, flowlib
+depends = mcl_player, flowlib, mcl_title
 optional_depends = mcl_core, doc_identifier
 
 
diff --git a/mods/ENTITIES/mcl_minecarts/init.lua b/mods/ENTITIES/mcl_minecarts/init.lua
index e33e120a14..a76ab538af 100644
--- a/mods/ENTITIES/mcl_minecarts/init.lua
+++ b/mods/ENTITIES/mcl_minecarts/init.lua
@@ -646,7 +646,7 @@ register_minecart(
 				if player then
 					mcl_player.player_set_animation(player, "sit" , 30)
 					player:set_eye_offset({x=0, y=-5.5, z=0},{x=0, y=-4, z=0})
-					mcl_tmp_message.message(clicker, S("Sneak to dismount"))
+					mcl_title.set(clicker, "actionbar", {text=S("Sneak to dismount"), color="white", stay=3})
 				end
 			end, name)
 		end
diff --git a/mods/ENTITIES/mcl_minecarts/mod.conf b/mods/ENTITIES/mcl_minecarts/mod.conf
index 9fff9175df..3b8ae55514 100644
--- a/mods/ENTITIES/mcl_minecarts/mod.conf
+++ b/mods/ENTITIES/mcl_minecarts/mod.conf
@@ -1,6 +1,6 @@
 name = mcl_minecarts
 author = Krock
 description = Minecarts are vehicles to move players quickly on rails.
-depends = mcl_explosions, mcl_core, mcl_sounds, mcl_player, mcl_achievements, mcl_chests, mcl_furnaces, mesecons_commandblock, mcl_hoppers, mcl_tnt, mesecons
+depends = mcl_title, mcl_explosions, mcl_core, mcl_sounds, mcl_player, mcl_achievements, mcl_chests, mcl_furnaces, mesecons_commandblock, mcl_hoppers, mcl_tnt, mesecons
 optional_depends = doc_identifier, mcl_wip
 
diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index 48c3a909f7..03fe176147 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -45,7 +45,7 @@ local player_params = {}
 
 minetest.register_on_joinplayer(function(player)
 	local playername = player:get_player_name()
-	player_params[playername] = {
+	player_params[player] = {
 		stay = gametick_to_secondes(mcl_title.defaults.stay),
 		--fadeIn = gametick_to_secondes(mcl_title.defaults.fadein),
 		--fadeOut = gametick_to_secondes(mcl_title.defaults.fadeout),
@@ -127,14 +127,13 @@ function mcl_title.set(player, type, data)
 		return false
 	end
 
-	--TODO: enable this code then Fleckenstein's pr get merged (in about 5-6 years)
+	--TODO: enable this code then Fleckenstein's pr get merged (in about 5-6 years lol)
 
 	--if data.bold == nil then data.bold = false end
 	--if data.italic == nil then data.italic = false end
 
 	player:hud_change(huds_idx[type][player], "text", data.text)
 	player:hud_change(huds_idx[type][player], "number", hex_color)
-
 	hud_hide_timeouts[type][player:get_player_name()] = data.stay or mcl_title.params_get(player).stay
 	return true
 end
diff --git a/mods/ITEMS/mcl_beds/functions.lua b/mods/ITEMS/mcl_beds/functions.lua
index dc9afe2bae..f323ca4c72 100644
--- a/mods/ITEMS/mcl_beds/functions.lua
+++ b/mods/ITEMS/mcl_beds/functions.lua
@@ -330,7 +330,7 @@ function mcl_beds.on_rightclick(pos, player, is_top)
 			message = select(2, lay_down(player, ppos, other))
 		end
 		if message then
-			mcl_tmp_message.message(player, message)
+			mcl_title.set(player, "actionbar", {text=message, color="white", stay=3})
 		end
 	else
 		lay_down(player, nil, nil, false)

From c31c852a6ea63eb2ffed49089881866fb59df0ed Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Tue, 20 Jul 2021 16:14:34 +0200
Subject: [PATCH 09/12] add documentation

---
 mods/ENTITIES/mcl_boats/init.lua     |  2 +-
 mods/ENTITIES/mcl_minecarts/init.lua |  2 +-
 mods/HUD/mcl_title/API.md            | 42 ++++++++++++++++++++++++++++
 mods/HUD/mcl_title/init.lua          |  2 +-
 mods/ITEMS/mcl_beds/functions.lua    |  2 +-
 5 files changed, 46 insertions(+), 4 deletions(-)
 create mode 100644 mods/HUD/mcl_title/API.md

diff --git a/mods/ENTITIES/mcl_boats/init.lua b/mods/ENTITIES/mcl_boats/init.lua
index e81e9ffc5d..311b07882f 100644
--- a/mods/ENTITIES/mcl_boats/init.lua
+++ b/mods/ENTITIES/mcl_boats/init.lua
@@ -84,7 +84,7 @@ local function attach_object(self, obj)
 			end
 		end, name)
 		obj:set_look_horizontal(yaw)
-		mcl_title.set(obj, "actionbar", {text=S("Sneak to dismount"), color="white", stay=3})
+		mcl_title.set(obj, "actionbar", {text=S("Sneak to dismount"), color="white", stay=60})
 	else
 		obj:get_luaentity()._old_visual_size = visual_size
 	end
diff --git a/mods/ENTITIES/mcl_minecarts/init.lua b/mods/ENTITIES/mcl_minecarts/init.lua
index a76ab538af..4d3873cc23 100644
--- a/mods/ENTITIES/mcl_minecarts/init.lua
+++ b/mods/ENTITIES/mcl_minecarts/init.lua
@@ -646,7 +646,7 @@ register_minecart(
 				if player then
 					mcl_player.player_set_animation(player, "sit" , 30)
 					player:set_eye_offset({x=0, y=-5.5, z=0},{x=0, y=-4, z=0})
-					mcl_title.set(clicker, "actionbar", {text=S("Sneak to dismount"), color="white", stay=3})
+					mcl_title.set(clicker, "actionbar", {text=S("Sneak to dismount"), color="white", stay=60})
 				end
 			end, name)
 		end
diff --git a/mods/HUD/mcl_title/API.md b/mods/HUD/mcl_title/API.md
new file mode 100644
index 0000000000..50614be4f1
--- /dev/null
+++ b/mods/HUD/mcl_title/API.md
@@ -0,0 +1,42 @@
+# mcl_title
+
+Allow mods to show messages in the hud of players.
+
+## mcl_title.set(player, type, data)
+
+Show a hud message of `type` to player `player` with `data` as params.
+
+The element will stay for the per-player param `stay` or `data.stay` (in gametick which is 1/20 second).
+
+Here is a usage exemple:
+
+```lua
+--show a title in the HUD with minecraft color "gold" 
+mcl_title.set(player, "title", {text="dummy text", color="gold"})
+
+--show a subtitle in the HUD with hex color "#612D2D" 
+mcl_title.set(player, "subtitle", {text="dummy subtitle", color="#612D2D"})
+
+--show an actionbar in the HUD (above the hotbar) with minecraft color "red"
+mcl_title.set(player, "subtitle", {text="dummy actionbar", color="red"})
+
+--show a title in the HUD with minecraft color "gold" staying for 3 seconds (override stay setting)
+mcl_title.set(player, "title", {text="dummy text", color="gold", stay=3})
+```
+
+## mcl_title.remove(player, type)
+
+Hide HUD element of type `type` for player `player`.
+
+## mcl_title.clear(player)
+
+Remove every title/subtitle/actionbar from a player.
+Basicaly run `mcl_title.remove(player, type)` for every type.
+
+## mcl_title.params_set(player, params)
+
+Allow mods to set `stay` and upcomming `fadeIn`/`fadeOut` params.
+
+```lua
+mcl_title.params_set(player, {stay = 600}) --elements with no 'data.stay' field will stay during 30s (600/20)
+```
\ No newline at end of file
diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index 03fe176147..d1dbece4b4 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -134,7 +134,7 @@ function mcl_title.set(player, type, data)
 
 	player:hud_change(huds_idx[type][player], "text", data.text)
 	player:hud_change(huds_idx[type][player], "number", hex_color)
-	hud_hide_timeouts[type][player:get_player_name()] = data.stay or mcl_title.params_get(player).stay
+	hud_hide_timeouts[type][player:get_player_name()] = gametick_to_secondes(data.stay) or mcl_title.params_get(player).stay
 	return true
 end
 
diff --git a/mods/ITEMS/mcl_beds/functions.lua b/mods/ITEMS/mcl_beds/functions.lua
index f323ca4c72..e196f69ade 100644
--- a/mods/ITEMS/mcl_beds/functions.lua
+++ b/mods/ITEMS/mcl_beds/functions.lua
@@ -330,7 +330,7 @@ function mcl_beds.on_rightclick(pos, player, is_top)
 			message = select(2, lay_down(player, ppos, other))
 		end
 		if message then
-			mcl_title.set(player, "actionbar", {text=message, color="white", stay=3})
+			mcl_title.set(player, "actionbar", {text=message, color="white", stay=60})
 		end
 	else
 		lay_down(player, nil, nil, false)

From 58a292a4f3edcf6816936b89a6b32275fb785299 Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Mon, 16 Aug 2021 13:48:08 +0200
Subject: [PATCH 10/12] fix inconsistency

---
 mods/HUD/mcl_title/init.lua | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index d1dbece4b4..ffdc456391 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -36,7 +36,11 @@ local string = string
 local pairs = pairs
 
 local function gametick_to_secondes(gametick)
-	return gametick / 20
+	if gametick then
+		return gametick / 20
+	else
+		return nil
+	end
 end
 
 
@@ -46,9 +50,9 @@ local player_params = {}
 minetest.register_on_joinplayer(function(player)
 	local playername = player:get_player_name()
 	player_params[player] = {
-		stay = gametick_to_secondes(mcl_title.defaults.stay),
-		--fadeIn = gametick_to_secondes(mcl_title.defaults.fadein),
-		--fadeOut = gametick_to_secondes(mcl_title.defaults.fadeout),
+		stay = mcl_title.defaults.stay,
+		--fadeIn = mcl_title.defaults.fadein,
+		--fadeOut = mcl_title.defaults.fadeout,
 	}
 	local _, hex_color = get_color("white") 
 	huds_idx.title[player] = player:hud_add({
@@ -106,9 +110,9 @@ end)
 
 function mcl_title.params_set(player, data)
 	player_params[player] = {
-		stay = gametick_to_secondes(data.stay) or gametick_to_secondes(mcl_title.defaults.stay),
-		--fadeIn = gametick_to_secondes(data.fadeIn) or gametick_to_secondes(mcl_title.defaults.fadein),
-		--fadeOut = gametick_to_secondes(data.fadeOut) or gametick_to_secondes(mcl_title.defaults.fadeout),
+		stay = data.stay or mcl_title.defaults.stay,
+		--fadeIn = data.fadeIn or mcl_title.defaults.fadein,
+		--fadeOut = data.fadeOut or mcl_title.defaults.fadeout,
 	}
 end
 
@@ -134,7 +138,7 @@ function mcl_title.set(player, type, data)
 
 	player:hud_change(huds_idx[type][player], "text", data.text)
 	player:hud_change(huds_idx[type][player], "number", hex_color)
-	hud_hide_timeouts[type][player:get_player_name()] = gametick_to_secondes(data.stay) or mcl_title.params_get(player).stay
+	hud_hide_timeouts[type][player:get_player_name()] = gametick_to_secondes(data.stay) or gametick_to_secondes(mcl_title.params_get(player).stay)
 	return true
 end
 

From 40898d3e9dfeb492ecaca2621308c8c125ef5471 Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Mon, 16 Aug 2021 14:19:50 +0200
Subject: [PATCH 11/12] WIP bold and italic support

---
 mods/HUD/mcl_title/init.lua | 38 +++++++++++++++++++++++++------------
 1 file changed, 26 insertions(+), 12 deletions(-)

diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index ffdc456391..933158d20b 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -43,6 +43,23 @@ local function gametick_to_secondes(gametick)
 	end
 end
 
+--https://github.com/minetest/minetest/blob/b3b075ea02034306256b486dd45410aa765f035a/doc/lua_api.txt#L8477
+
+local function style_to_bits(bold, italic)
+	if bold then
+		if italic then
+			return 3
+		else
+			return 1
+		end
+	else
+		if italic then
+			return 2
+		else
+			return 0
+		end
+	end
+end
 
 --PARAMS SYSTEM
 local player_params = {}
@@ -60,8 +77,7 @@ minetest.register_on_joinplayer(function(player)
 		position  = mcl_title.layout.title.position,
 		alignment = mcl_title.layout.title.alignment,
 		text      = "",
-		--bold    = data.bold,
-		--italic  = data.italic,
+		style = 0,
 		size      = {x = mcl_title.layout.title.size},
 		number    = hex_color,
 		z_index   = 100,
@@ -71,8 +87,7 @@ minetest.register_on_joinplayer(function(player)
 		position  = mcl_title.layout.subtitle.position,
 		alignment = mcl_title.layout.subtitle.alignment,
 		text      = "",
-		--bold    = data.bold,
-		--italic  = data.italic,
+		style = 0,
 		size      = {x = mcl_title.layout.subtitle.size},
 		number    = hex_color,
 		z_index   = 100,
@@ -82,8 +97,7 @@ minetest.register_on_joinplayer(function(player)
 		position  = mcl_title.layout.actionbar.position,
 		offset    = {x = 0, y = -210},
 		alignment = mcl_title.layout.actionbar.alignment,
-		--bold    = data.bold,
-		--italic  = data.italic,
+		style = 0,
 		text      = "",
 		size      = {x = mcl_title.layout.actionbar.size},
 		number    = hex_color,
@@ -131,13 +145,12 @@ function mcl_title.set(player, type, data)
 		return false
 	end
 
-	--TODO: enable this code then Fleckenstein's pr get merged (in about 5-6 years lol)
-
-	--if data.bold == nil then data.bold = false end
-	--if data.italic == nil then data.italic = false end
-
 	player:hud_change(huds_idx[type][player], "text", data.text)
 	player:hud_change(huds_idx[type][player], "number", hex_color)
+
+	--apply bold and italic
+	player:hud_change(huds_idx[type][player], "style", style_to_bits(data.bold, data.italic))
+
 	hud_hide_timeouts[type][player:get_player_name()] = gametick_to_secondes(data.stay) or gametick_to_secondes(mcl_title.params_get(player).stay)
 	return true
 end
@@ -145,6 +158,7 @@ end
 function mcl_title.remove(player, type)
 	if player then
 		player:hud_change(huds_idx[type][player], "text", "")
+		player:hud_change(huds_idx[type][player], "style", 0) --no styling
 	end
 end
 
@@ -184,7 +198,7 @@ end)
 minetest.register_chatcommand("title", {
 	func = function(name, param)
 		local player = minetest.get_player_by_name(name)
-		mcl_title.set(player, "title", {text=param, color="gold"})
+		mcl_title.set(player, "title", {text=param, color="gold", bold=true, italic=true})
 	end,
 })
 

From df4b8e64cc153ba70457a199661e1e6e92e30bf9 Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Thu, 19 Aug 2021 19:21:33 +0200
Subject: [PATCH 12/12] finish `mcl_title` API + doc

---
 mods/HUD/mcl_title/API.md         |  8 ++++++
 mods/HUD/mcl_title/init.lua       | 28 +++++++++++---------
 mods/HUD/mcl_tmp_message/API.md   |  7 -----
 mods/HUD/mcl_tmp_message/init.lua | 44 -------------------------------
 mods/HUD/mcl_tmp_message/mod.conf |  3 ---
 5 files changed, 23 insertions(+), 67 deletions(-)
 delete mode 100644 mods/HUD/mcl_tmp_message/API.md
 delete mode 100644 mods/HUD/mcl_tmp_message/init.lua
 delete mode 100644 mods/HUD/mcl_tmp_message/mod.conf

diff --git a/mods/HUD/mcl_title/API.md b/mods/HUD/mcl_title/API.md
index 50614be4f1..97d75ece83 100644
--- a/mods/HUD/mcl_title/API.md
+++ b/mods/HUD/mcl_title/API.md
@@ -39,4 +39,12 @@ Allow mods to set `stay` and upcomming `fadeIn`/`fadeOut` params.
 
 ```lua
 mcl_title.params_set(player, {stay = 600}) --elements with no 'data.stay' field will stay during 30s (600/20)
+```
+
+## mcl_title.params_get(player)
+
+Get `stay` and upcomming `fadeIn` and `fadeOut` params of a player as a table.
+
+```lua
+mcl_title.params_get(player)
 ```
\ No newline at end of file
diff --git a/mods/HUD/mcl_title/init.lua b/mods/HUD/mcl_title/init.lua
index 933158d20b..2ea1571c82 100644
--- a/mods/HUD/mcl_title/init.lua
+++ b/mods/HUD/mcl_title/init.lua
@@ -32,7 +32,7 @@ mcl_title.layout.actionbar = {position = {x = 0.5, y = 1}, alignment = {x = 0, y
 
 local get_color = mcl_util.get_color
 
-local string = string
+--local string = string
 local pairs = pairs
 
 local function gametick_to_secondes(gametick)
@@ -44,7 +44,7 @@ local function gametick_to_secondes(gametick)
 end
 
 --https://github.com/minetest/minetest/blob/b3b075ea02034306256b486dd45410aa765f035a/doc/lua_api.txt#L8477
-
+--[[
 local function style_to_bits(bold, italic)
 	if bold then
 		if italic then
@@ -60,24 +60,25 @@ local function style_to_bits(bold, italic)
 		end
 	end
 end
+]]
 
 --PARAMS SYSTEM
 local player_params = {}
 
 minetest.register_on_joinplayer(function(player)
-	local playername = player:get_player_name()
+	--local playername = player:get_player_name()
 	player_params[player] = {
 		stay = mcl_title.defaults.stay,
 		--fadeIn = mcl_title.defaults.fadein,
 		--fadeOut = mcl_title.defaults.fadeout,
 	}
-	local _, hex_color = get_color("white") 
+	local _, hex_color = get_color("white")
 	huds_idx.title[player] = player:hud_add({
 		hud_elem_type = "text",
 		position  = mcl_title.layout.title.position,
 		alignment = mcl_title.layout.title.alignment,
 		text      = "",
-		style = 0,
+		--style = 0,
 		size      = {x = mcl_title.layout.title.size},
 		number    = hex_color,
 		z_index   = 100,
@@ -87,7 +88,7 @@ minetest.register_on_joinplayer(function(player)
 		position  = mcl_title.layout.subtitle.position,
 		alignment = mcl_title.layout.subtitle.alignment,
 		text      = "",
-		style = 0,
+		--style = 0,
 		size      = {x = mcl_title.layout.subtitle.size},
 		number    = hex_color,
 		z_index   = 100,
@@ -97,7 +98,7 @@ minetest.register_on_joinplayer(function(player)
 		position  = mcl_title.layout.actionbar.position,
 		offset    = {x = 0, y = -210},
 		alignment = mcl_title.layout.actionbar.alignment,
-		style = 0,
+		--style = 0,
 		text      = "",
 		size      = {x = mcl_title.layout.actionbar.size},
 		number    = hex_color,
@@ -116,7 +117,7 @@ minetest.register_on_leaveplayer(function(player)
 	huds_idx.subtitle[player] = nil
 	huds_idx.actionbar[player] = nil
 
-	--remove timers form list
+	--remove timers from list
 	hud_hide_timeouts.title[playername] = nil
 	hud_hide_timeouts.subtitle[playername] = nil
 	hud_hide_timeouts.actionbar[playername] = nil
@@ -149,7 +150,7 @@ function mcl_title.set(player, type, data)
 	player:hud_change(huds_idx[type][player], "number", hex_color)
 
 	--apply bold and italic
-	player:hud_change(huds_idx[type][player], "style", style_to_bits(data.bold, data.italic))
+	--player:hud_change(huds_idx[type][player], "style", style_to_bits(data.bold, data.italic))
 
 	hud_hide_timeouts[type][player:get_player_name()] = gametick_to_secondes(data.stay) or gametick_to_secondes(mcl_title.params_get(player).stay)
 	return true
@@ -158,7 +159,7 @@ end
 function mcl_title.remove(player, type)
 	if player then
 		player:hud_change(huds_idx[type][player], "text", "")
-		player:hud_change(huds_idx[type][player], "style", 0) --no styling
+		--player:hud_change(huds_idx[type][player], "style", 0) --no styling
 	end
 end
 
@@ -193,8 +194,8 @@ minetest.register_globalstep(function(dtime)
 end)
 
 
---TEMP STUFF!!
---TODO: remove then testing/tweaking done
+--DEBUG STUFF!!
+--[[
 minetest.register_chatcommand("title", {
 	func = function(name, param)
 		local player = minetest.get_player_by_name(name)
@@ -231,4 +232,5 @@ minetest.register_chatcommand("all", {
 		mcl_title.set(player, "subtitle", {text=param, color="gold"})
 		mcl_title.set(player, "actionbar", {text=param, color="gold"})
 	end,
-})
\ No newline at end of file
+})
+]]
\ No newline at end of file
diff --git a/mods/HUD/mcl_tmp_message/API.md b/mods/HUD/mcl_tmp_message/API.md
deleted file mode 100644
index 0a3fc06a33..0000000000
--- a/mods/HUD/mcl_tmp_message/API.md
+++ /dev/null
@@ -1,7 +0,0 @@
-# mcl_temp_message
-
-Allow mods to show short messages in the hud of players.
-
-## mcl_tmp_message.message(player, message)
-
-Show above the hotbar a hud message <message> to player <player>.
\ No newline at end of file
diff --git a/mods/HUD/mcl_tmp_message/init.lua b/mods/HUD/mcl_tmp_message/init.lua
deleted file mode 100644
index 1456cd5922..0000000000
--- a/mods/HUD/mcl_tmp_message/init.lua
+++ /dev/null
@@ -1,44 +0,0 @@
-mcl_tmp_message = {}
-
-local huds = {}
-local hud_hide_timeouts = {}
-
-function mcl_tmp_message.message(player, message)
-	local name = player:get_player_name()
-	player:hud_change(huds[name], "text", message)
-	hud_hide_timeouts[name] = 3
-end
-
-minetest.register_on_joinplayer(function(player)
-	huds[player:get_player_name()] = player:hud_add({
-		hud_elem_type = "text",
-		position = {x=0.5, y=1},
-		offset = {x = 0, y = -210},
-		alignment = {x=0, y=0},
-		number = 0xFFFFFF ,
-		text = "",
-		z_index = 100,
-	})
-end)
-
-minetest.register_on_leaveplayer(function(player)
-	local name = player:get_player_name()
-	huds[name] = nil
-	hud_hide_timeouts[name] = nil
-end)
-
-minetest.register_globalstep(function(dtime)
-	local new_timeouts = {}
-	for name, timeout in pairs(hud_hide_timeouts) do
-		timeout = timeout - dtime
-		if timeout <= 0 then
-			local player = minetest.get_player_by_name(name)
-			if player then
-				player:hud_change(huds[name], "text", "")
-			end
-		else
-			new_timeouts[name] = timeout
-		end
-	end
-	hud_hide_timeouts = new_timeouts
-end)
diff --git a/mods/HUD/mcl_tmp_message/mod.conf b/mods/HUD/mcl_tmp_message/mod.conf
deleted file mode 100644
index ad453643e8..0000000000
--- a/mods/HUD/mcl_tmp_message/mod.conf
+++ /dev/null
@@ -1,3 +0,0 @@
-name = mcl_tmp_message
-author = Fleckenstein
-description = A simple API to show a temporary message to a player