Bram
/
VoxeLibre
forked from VoxeLibre/VoxeLibre
1
0
Fork 0
Code Pull Requests Activity

Fix creative mode inventory search crash 

Before this patch it was possible for any user to to crash Minetest in
creative mode. This was possible because queries in the search field
were interpreted as search patterns for string.find().

A search for a single square bracket would reliably crash the server.
Also, a search for 6000 times the string “a?” would hang the server.

The solution to both bugs is to not interpret the query as a pattern.
This commit is contained in:
My favourite Minetest cheat clients are Dragonfire and Waspsaliva. 2022-11-15 04:41:01 +01:00 committed by cora
parent 12a31ee5ba
commit 94960b64d4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mods/HUD/mcl_inventory/creative.lua
View File

@ -117,7 +117,7 @@ local function filter_item(name, description, lang, filter)
else else
desc = string.lower(minetest.get_translated_string(lang, description)) desc = string.lower(minetest.get_translated_string(lang, description))
end end
return string.find(name, filter) or string.find(desc, filter) return string.find(name, filter, nil, true) or string.find(desc, filter, nil, true)
end end
local function set_inv_search(filter, player) local function set_inv_search(filter, player)