From 53715212a210d31b965f1f9d482cba528d6fc700 Mon Sep 17 00:00:00 2001
From: cora <coradelamouche@gmx.ch>
Date: Mon, 31 Jan 2022 21:35:21 +0100
Subject: [PATCH] remove unnecessary on_dimensionchange

---
 mods/ENVIRONMENT/mcl_weather/rain.lua | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/mods/ENVIRONMENT/mcl_weather/rain.lua b/mods/ENVIRONMENT/mcl_weather/rain.lua
index 191062bcdc..f21bbc13cd 100644
--- a/mods/ENVIRONMENT/mcl_weather/rain.lua
+++ b/mods/ENVIRONMENT/mcl_weather/rain.lua
@@ -29,7 +29,7 @@ local psdef= {
 	minpos = vector.new(-6,3,-6),
 	maxpos = vector.new(6,15,6),
 	minvel = vector.new(-vel,-falling_speed,-vel),
-	maxvel = math.random(vel,-falling_speed+vel,vel),
+	maxvel = vector.new(vel,-falling_speed+vel,vel),
 	minacc = vector.new(0,0,0),
 	maxacc = vector.new(0,-0.4,0),
 	minexptime = 0.5,
@@ -119,19 +119,6 @@ function mcl_weather.rain.remove_player(player)
 	end
 end
 
-mcl_worlds.register_on_dimension_change(function(player, dimension)
-	if dimension ~= "overworld" and dimension ~= "void" then
-		mcl_weather.rain.remove_sound(player)
-		mcl_weather.rain.remove_player(player)
-	elseif dimension == "overworld" then
-		mcl_weather.rain.update_sound(player)
-		if mcl_weather.rain.raining then
-			mcl_weather.rain.add_rain_particles(player)
-			mcl_weather.rain.add_player(player)
-		end
-	end
-end)
-
 -- adds and removes rain sound depending how much rain particles around player currently exist.
 -- have few seconds delay before each check to avoid on/off sound too often
 -- when player stay on 'edge' where sound should play and stop depending from random raindrop appearance.