AFCMS commented on pull request VoxeLibre/VoxeLibre#4019 2023-11-19 12:01:40 +01:00
Rework Stonecutter functionality

Screenshot of V4 formspec:

image

AFCMS commented on pull request VoxeLibre/VoxeLibre#4019 2023-11-19 11:59:46 +01:00
Rework Stonecutter functionality

https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CONTRIBUTING.md#code-guidelines

Not explicitly specified in the code guidelines, but was using inconsistant spacing around ..

AFCMS commented on pull request VoxeLibre/VoxeLibre#4019 2023-11-19 11:56:13 +01:00
Rework Stonecutter functionality

I really don't see a reason to do so.

It wasn't used anywhere in MCL and IMO its not a good idea to allow passing parameters in a format that doesn't make much sense.

Same for the math.floor

AFCMS commented on pull request VoxeLibre/VoxeLibre#4019 2023-11-19 11:41:09 +01:00
Rework Stonecutter functionality

Can't a player cheat and use stonecutter by sending the formspec from anywhere? I know this is low concern, but this thought just crossed my mind.

Technically yes, but that's already the case…

AFCMS created pull request VoxeLibre/VoxeLibre#4019 2023-11-19 01:54:32 +01:00
WIP: Rework Stonecutter functionality
AFCMS pushed to stone_cutter_rework at AFCMS/MineClone2 2023-11-19 01:49:32 +01:00
9ad6fb9cec Rework Stonecutter
eb166faf5e Add utility functions to clean inventory lists
44fcbd4ba8 Add basic table ordered keys iterator
26fa42924a Updated README
5275a772e4 Removed old implementation groups
Compare 10 commits »
AFCMS created branch stone_cutter_rework in AFCMS/MineClone2 2023-11-19 01:49:32 +01:00
AFCMS approved VoxeLibre/VoxeLibre#4006 2023-11-19 01:47:26 +01:00
French translation update

Looks good.

AFCMS commented on pull request VoxeLibre/VoxeLibre#3999 2023-11-17 15:46:45 +01:00
Add stonecutter functionality

I will do a PR on this branch with a V4 formspec and also remove dependency on node meta/inventory just like crafting table.

AFCMS pushed to master at AFCMS/MineClone2 2023-11-14 19:09:10 +01:00
a764818e13 Add a new 'pumpkin' group (#4012)
32ef89aca3 Fix minor README's imperfections (#4001)
accb8742dd Merge pull request 'Make golem go home. Fixes #3288' (#3929) from golem_nav into master
71282e196e Move mob nav hacks to Experimental
89c97690c8 Add a setting to enable mod nav hacks
Compare 63 commits »
AFCMS commented on pull request VoxeLibre/VoxeLibre#3980 2023-10-31 18:15:05 +01:00
hopper reimplementation

Type Vecotr -> Vector

AFCMS commented on issue VoxeLibre/VoxeLibre#3969 2023-10-18 21:48:50 +02:00
problem protector mod WARNING FIXED SERVERS ALL

99% chances it's the server owner fault. Or the protection mod fault. (do you know which version/edition of the mod it is?)

Most likely the mod is just no longer activated, since the nodes are…

AFCMS pushed to master at AFCMS/MineClone2 2023-10-18 21:42:47 +02:00
3d7155c1b9 Merge pull request 'Raise player eye height to 1.6 blocks.' (#3967) from Dark/MineClone2:master into master
e3ab94809e Merge pull request 'Fixed a crash in minetest vector code that isn't propogated to lua.' (#3966) from fix_rotate_around_axis_crash into master
a66be39d9b Raise player eye height to 1.6 blocks.
3564f6ebde Fixed a crash in minetest vector code that isn't propogated to lua. Create util for ease of use.
f99ae93bf6 Merge pull request 'fix crash when opening a chest that has an unknow node on it' (#3964) from pepebotella/MineClone2:chest-under-unknow into master
Compare 80 commits »
AFCMS commented on issue VoxeLibre/VoxeLibre#3962 2023-10-12 10:57:14 +02:00
Totem blocks /kill

What I see in favor of implementing the MC behavior is the automation with command blocks in adventure maps. Currently there is no way to kill someone with a totem in hand properly (without…

AFCMS commented on pull request VoxeLibre/VoxeLibre#3951 2023-10-07 14:53:29 +02:00
WIP: Potions API redo

Nice someone actually look into that code :D

It definitely needed some improvements.

When this PR will be finished, I will do a full review with pleasure (please ping me on discord, I am…

AFCMS approved VoxeLibre/VoxeLibre#3784 2023-10-01 22:27:57 +02:00
add 1.20 armor trims

Works, good job 👍

AFCMS commented on pull request VoxeLibre/VoxeLibre#3784 2023-09-22 22:09:34 +02:00
add 1.20 armor trims

snippets only provide the itemstring, while this is a meta dependent story, gonna try _mcl_generate_description

@chmodsayshello Its passed as the third parameter.

https://git.minetest.lan

AFCMS pushed to master at AFCMS/MineClone2 2023-09-17 17:18:34 +02:00
b4c693bb20 Merge pull request 'Campfire Updates' (#3769) from campfire_update into master
bd46428d65 Updated credits
9e53efbc3e Fix campfire smoke timing
6b36abfe91 Fix credits
49e7449d7f Implement feedback and add credit
Compare 50 commits »
AFCMS opened issue VoxeLibre/VoxeLibre#3940 2023-09-16 20:30:28 +02:00
Reworked Branding
AFCMS commented on issue VoxeLibre/VoxeLibre#3903 2023-09-16 19:19:28 +02:00
Simple skins as skin templates

I would like minecraft skins support coming to MCL2 before continuing to work on my skin server.

I have something like 3 weeks of vacation from now so maybe I will continue working on it soon.