AFCMS commented on pull request VoxeLibre/VoxeLibre#4024 2023-11-22 09:33:11 +01:00
Colored Leather Armor
AFCMS commented on pull request VoxeLibre/VoxeLibre#4024 2023-11-22 09:25:01 +01:00
Colored Leather Armor

Not working, should addition two colors from dye+dye or item+dye to get an output color for the armor piece.

AFCMS commented on pull request VoxeLibre/VoxeLibre#4024 2023-11-22 09:23:51 +01:00
Colored Leather Armor

Right clicking on cauldron should remove the color (not currently implemented)

AFCMS commented on pull request VoxeLibre/VoxeLibre#4024 2023-11-22 09:21:38 +01:00
Colored Leather Armor

You have to manually handle the enchanting glint, as mcl_enchanting will not take care of it since its a function and not a string.

AFCMS created pull request VoxeLibre/VoxeLibre#4024 2023-11-22 09:20:35 +01:00
WIP: [NOT MAINTAINED] Colored Leather Armor
AFCMS pushed to colored-leather-2 at AFCMS/MineClone2 2023-11-22 09:16:51 +01:00
cf248397e7 Colored Leather Armor
4df6f82c64 Fix spanish translation errors (#4018)
6ee2dbe70c Add MineCraft like sleeping player hud (#4011)
613ab897b2 Merge pull request 'Fix item not dropping at tool last use' (#4009) from tool_destruction into master
e53d9ec8d7 Added comments
Compare 3852 commits »
AFCMS pushed to colored-leather-2 at AFCMS/MineClone2 2023-11-22 09:15:22 +01:00
acd91686af Colored Leather Armor
AFCMS created branch colored-leather-2 in AFCMS/MineClone2 2023-11-22 09:15:22 +01:00
AFCMS pushed to stone_cutter_rework at AFCMS/MineClone2 2023-11-22 09:12:06 +01:00
6ca0f33e42 Make inventory use the util functions
AFCMS commented on issue VoxeLibre/VoxeLibre#4023 2023-11-21 13:37:19 +01:00
Ability to paint leather armor

It's possible to implement using the available APIs in Minetest and MCL2 (item meta based).

I worked on this in the past but never got the time to finish.

If someone is interested into…

AFCMS commented on pull request VoxeLibre/VoxeLibre#4019 2023-11-21 11:50:13 +01:00
Rework Stonecutter functionality

These LuaLS annotations are not really working for some reason.

AFCMS commented on pull request VoxeLibre/VoxeLibre#4019 2023-11-19 12:01:40 +01:00
Rework Stonecutter functionality

Screenshot of V4 formspec:

image

AFCMS commented on pull request VoxeLibre/VoxeLibre#4019 2023-11-19 11:59:46 +01:00
Rework Stonecutter functionality

https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CONTRIBUTING.md#code-guidelines

Not explicitly specified in the code guidelines, but was using inconsistant spacing around ..

AFCMS commented on pull request VoxeLibre/VoxeLibre#4019 2023-11-19 11:56:13 +01:00
Rework Stonecutter functionality

I really don't see a reason to do so.

It wasn't used anywhere in MCL and IMO its not a good idea to allow passing parameters in a format that doesn't make much sense.

Same for the math.floor

AFCMS commented on pull request VoxeLibre/VoxeLibre#4019 2023-11-19 11:41:09 +01:00
Rework Stonecutter functionality

Can't a player cheat and use stonecutter by sending the formspec from anywhere? I know this is low concern, but this thought just crossed my mind.

Technically yes, but that's already the case…

AFCMS created pull request VoxeLibre/VoxeLibre#4019 2023-11-19 01:54:32 +01:00
WIP: Rework Stonecutter functionality
AFCMS pushed to stone_cutter_rework at AFCMS/MineClone2 2023-11-19 01:49:32 +01:00
9ad6fb9cec Rework Stonecutter
eb166faf5e Add utility functions to clean inventory lists
44fcbd4ba8 Add basic table ordered keys iterator
26fa42924a Updated README
5275a772e4 Removed old implementation groups
Compare 10 commits »
AFCMS created branch stone_cutter_rework in AFCMS/MineClone2 2023-11-19 01:49:32 +01:00
AFCMS approved VoxeLibre/VoxeLibre#4006 2023-11-19 01:47:26 +01:00
French translation update

Looks good.

AFCMS commented on pull request VoxeLibre/VoxeLibre#3999 2023-11-17 15:46:45 +01:00
Add stonecutter functionality

I will do a PR on this branch with a V4 formspec and also remove dependency on node meta/inventory just like crafting table.