From 1a7b455fd20a7fc818b3b303cfb7d7084e11ce80 Mon Sep 17 00:00:00 2001
From: Wuzzy <almikes@aol.com>
Date: Sat, 10 Jun 2017 20:47:12 +0200
Subject: [PATCH] Fix item entity wiggle on flowing water

---
 mods/ENTITIES/mcl_item_entity/init.lua | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/mods/ENTITIES/mcl_item_entity/init.lua b/mods/ENTITIES/mcl_item_entity/init.lua
index c3fe025c3..a6aa7887d 100644
--- a/mods/ENTITIES/mcl_item_entity/init.lua
+++ b/mods/ENTITIES/mcl_item_entity/init.lua
@@ -231,6 +231,11 @@ core.register_entity(":__builtin:item", {
 
 	itemstring = '',
 	physical_state = true,
+	_flowing = false, -- item entity is currently flowing
+	-- States:
+	-- * "magnet": Attracted to a nearby player or item
+	-- * "flowing": Moving in a flowing liquid
+	-- * "normal": Affected by gravitiy
 	age = 0,
 
 	set_item = function(self, itemstring)
@@ -296,6 +301,7 @@ core.register_entity(":__builtin:item", {
 			always_collect = self.always_collect,
 			age = self.age,
 			_insta_collect = self._insta_collect,
+			_flowing = self._flowing,
 		})
 	end,
 
@@ -313,7 +319,7 @@ core.register_entity(":__builtin:item", {
 				--remember collection data
 				-- If true, can collect item without delay
 				self._insta_collect = data._insta_collect
-
+				self._flowing = data._flowing
 			end
 		else
 			self.itemstring = staticdata
@@ -322,6 +328,9 @@ core.register_entity(":__builtin:item", {
 			-- Intentionally default, since delayed collection is rare
 			self._insta_collect = true
 		end
+		if self._flowing == nil then
+			self._flowing = false
+		end
 		self._magnet_timer = 0
 		self._magnet_active = false
 		-- How long ago the last possible collector was detected. nil = none in this session
@@ -530,16 +539,20 @@ core.register_entity(":__builtin:item", {
 				-- Set new item moving speed into the direciton of the liquid
 				local newv = vector.multiply(vec, f)
 				self.object:setacceleration({x = 0, y = 0, z = 0})
-				-- FIXME: This makes the item wiggle on flowing water
 				self.object:setvelocity({x = newv.x, y = -0.22, z = newv.z})
 
-				self.object:setacceleration({x = 0, y = -get_gravity(), z = 0})
 				self.physical_state = true
+				self._flowing = true
 				self.object:set_properties({
 					physical = true
 				})
 				return
 			end
+		elseif self._flowing == true then
+			-- Disable flowing physics if not on/in flowing liquid
+			self._flowing = false
+			enable_physics(self.object, self)
+			return
 		end
 
 		-- If node is not registered or node is walkably solid and resting on nodebox